Merge branch 'cursor/trigger-failure-workflow-3038' into cursor/ftp-sftp-script-3038

packages/server/registry.js

@@ -690,7 +690,7 @@ export function createRegistry(server) {
       {
         workflow: opts.key,
         consecutiveFailures,
-        triggerWorkflow: failureConfig.workflowName,
+        onFailureWorkflow: failureConfig.workflowName,
         destination: destKey,
       },
       "triggering failure alert workflow",

packages/server/src/api/dashboard.js

@@ -63,9 +63,10 @@ export default function dashboardPluginFactory(registry) {
         }
       }
 
-      const [running, failed, recent] = await Promise.all([
+      const [running, streaks, failedEvents, recent] = await Promise.all([
         store.listRuns({ status: "running", limit: 10 }),
-        store.listRuns({ status: "failed", limit: 20 }),
+        store.listConsecutiveFailureStreaks({ minCount: 4, limit: 10 }),
+        store.listRuns({ status: "failed", limit: 5 }),
         store.listRuns({ limit: 10 }),
       ]);
 
@@ -76,9 +77,11 @@ export default function dashboardPluginFactory(registry) {
         brokenCount,
         running,
         needsAttention: {
-          failed,
+          consecutiveFailures: streaks.items,
+          consecutiveFailureCount: streaks.total,
           brokenWorkflows,
         },
+        failedEvents,
         recent,
       };
     });

packages/server/src/api/runs.js

@@ -17,6 +17,15 @@ export default async function runsPlugin(fastify) {
     return { runs };
   });
 
+  fastify.get("/consecutive-failures", async (req) => {
+    const q = /** @type {Record<string, string | undefined>} */ (req.query ?? {});
+    const limit = q.limit ? Number(q.limit) : undefined;
+    return store.listConsecutiveFailureStreaks({
+      minCount: 4,
+      limit: Number.isFinite(limit) ? limit : 200,
+    });
+  });
+
   fastify.get("/runs/:id", async (req, reply) => {
     const { id } = /** @type {{ id: string }} */ (req.params);
     const run = await store.getRun(id);

packages/server/src/api/workflows.js

@@ -28,7 +28,7 @@ function triggerSummary(owner, workflow) {
       path: isHttp && t?.path != null ? namespacedPath(owner, t.path) : t?.path ?? null,
       schedule: t?.schedule ?? null,
       onConsecutiveFailures: t?.onConsecutiveFailures ?? null,
-      triggerWorkflow: t?.triggerWorkflow ?? null,
+      onFailureWorkflow: t?.onFailureWorkflow ?? null,
       auth: isHttp ? authLabel(t?.auth) : null,
     };
   });

packages/server/store.js

@@ -293,6 +293,98 @@ export async function countConsecutiveFailures(workflow, triggerType, triggerDet
   return count;
 }
 
+const CONSECUTIVE_FAILURE_WINDOW = 5000;
+const STREAK_LAST_RUN_FIELDS = [
+  "id",
+  "owner",
+  "workflow",
+  "workflow_name",
+  "trigger_type",
+  "trigger_detail",
+  "status",
+  "started_at",
+  "finished_at",
+  "duration_ms",
+  "error",
+];
+
+/**
+ * Workflow+trigger groups currently in a trailing failure streak.
+ *
+ * @param {{
+ *   minCount?: number,
+ *   limit?: number,
+ * }} [opts]
+ * @returns {Promise<{
+ *   items: Array<{
+ *     consecutiveFailures: number,
+ *     workflow: string,
+ *     workflow_name: string | null,
+ *     owner: string,
+ *     trigger_type: string,
+ *     trigger_detail: string | null,
+ *     lastRun: {
+ *       id: string,
+ *       owner: string,
+ *       workflow: string,
+ *       workflow_name: string | null,
+ *       trigger_type: string,
+ *       trigger_detail: string | null,
+ *       status: string,
+ *       started_at: string,
+ *       finished_at: string | null,
+ *       duration_ms: number | null,
+ *       error: string | null,
+ *     },
+ *   }>,
+ *   total: number,
+ * }>}
+ */
+export async function listConsecutiveFailureStreaks(opts = {}) {
+  const minCount = Math.max(opts.minCount ?? 4, 1);
+  const limit = Math.min(Math.max(opts.limit ?? 100, 1), 200);
+
+  const rows = await db("workflow_runs")
+    .select(STREAK_LAST_RUN_FIELDS)
+    .whereIn("status", ["success", "failed"])
+    .orderBy("started_at", "desc")
+    .limit(CONSECUTIVE_FAILURE_WINDOW);
+
+  /** @type {Map<string, { count: number, done: boolean, lastRun: (typeof rows)[number] }>} */
+  const groups = new Map();
+  for (const row of rows) {
+    const key = `${row.workflow}\0${row.trigger_type}\0${row.trigger_detail ?? ""}`;
+    let group = groups.get(key);
+    if (!group) {
+      group = { count: 0, done: false, lastRun: row };
+      groups.set(key, group);
+    }
+    if (group.done) continue;
+    if (row.status === "failed") group.count += 1;
+    else group.done = true;
+  }
+
+  const streaks = [...groups.values()]
+    .filter((g) => g.lastRun.status === "failed" && g.count >= minCount)
+    .sort((a, b) => {
+      if (b.count !== a.count) return b.count - a.count;
+      return String(b.lastRun.started_at).localeCompare(String(a.lastRun.started_at));
+    });
+
+  return {
+    total: streaks.length,
+    items: streaks.slice(0, limit).map((g) => ({
+      consecutiveFailures: g.count,
+      workflow: g.lastRun.workflow,
+      workflow_name: g.lastRun.workflow_name,
+      owner: g.lastRun.owner,
+      trigger_type: g.lastRun.trigger_type,
+      trigger_detail: g.lastRun.trigger_detail,
+      lastRun: g.lastRun,
+    })),
+  };
+}
+
 /**
  * @returns {Promise<Record<string, { invocationCount: number, lastInvokedAt: string | null, lastStatus: string | null }>>}
  */

packages/server/trigger-failure.js

@@ -46,8 +46,7 @@ export function resolveFailureTriggerConfig(workflow, owner, runtimeTrigger) {
     if (!spec) continue;
 
     const threshold = Number(spec.onConsecutiveFailures);
-    const workflowName =
+    const workflowName = onFailureWorkflowName(spec);
-      typeof spec.triggerWorkflow === "string" ? spec.triggerWorkflow.trim() : "";
     if (!Number.isFinite(threshold) || threshold < 1 || workflowName.length === 0) {
       return null;
     }
@@ -59,6 +58,14 @@ export function resolveFailureTriggerConfig(workflow, owner, runtimeTrigger) {
   return null;
 }
 
+/**
+ * @param {Record<string, unknown>} trigger
+ */
+function onFailureWorkflowName(trigger) {
+  const value = trigger?.onFailureWorkflow;
+  return typeof value === "string" ? value.trim() : "";
+}
+
 /**
  * @param {unknown} workflow
  */
@@ -73,14 +80,13 @@ export async function validateWorkflowFailureTriggers(workflow) {
 
     const hasThreshold =
       trigger.onConsecutiveFailures != null && trigger.onConsecutiveFailures !== "";
-    const hasWorkflow =
+    const hasWorkflow = onFailureWorkflowName(trigger).length > 0;
-      typeof trigger.triggerWorkflow === "string" && trigger.triggerWorkflow.trim().length > 0;
 
     if (!hasThreshold && !hasWorkflow) continue;
 
     if (!hasThreshold || !hasWorkflow) {
       const err = new Error(
-        "onConsecutiveFailures and triggerWorkflow must both be set on a trigger",
+        "onConsecutiveFailures and onFailureWorkflow must both be set on a trigger",
       );
       err.statusCode = 400;
       throw err;

packages/server/workflows/default/detect-example-changes.yaml

@@ -8,7 +8,7 @@ scripts:
     config:
       url: https://example.com/
       outputVar: message
-      transform: >
+      transform: |
         data.hasChanges
           ? "example.com changed (fingerprint " & data.fingerprint & ")"
           : "example.com unchanged since " & data.fingerprintAt
@@ -16,3 +16,8 @@ triggers:
   - type: HTTP
     method: POST
     path: /detect-example
+  - type: cron
+    schedule: "* * * * *"
+    onConsecutiveFailures: 3
+    onFailureWorkflow: dev-zte-sms
+enabled: false

packages/server/workflows/default/jadwal-sholat-jakart.yaml

@@ -0,0 +1,50 @@
+name: Jadwal Solat Jakarta ntfy
+scripts:
+  - id: fetch
+    script: fetch-http.js
+    config:
+      url: https://kemenag.go.id/api/prayer-times/1301
+      method: GET
+      headers:
+        Content-Type: application/json
+        Accept: application/json
+  - id: transform
+    script: jsonata.js
+    config:
+      expression: |-
+        {
+          "title": data.httpResponse.data.date,
+          "message": "Imsak:" & data.httpResponse.data.imsak & "\n" &
+                     "Subuh:" & data.httpResponse.data.subuh & "\n" &
+                     "Dzuhur:" & data.httpResponse.data.dzuhur & "\n" &
+                     "Ashar:" & data.httpResponse.data.ashar & "\n" &
+                     "Maghrib:" & data.httpResponse.data.maghrib & "\n" &
+                     "Isya:" & data.httpResponse.data.isya
+        }
+    needs:
+      - fetch
+  - id: ntfy
+    script: ntfy.js
+    config:
+      url: $VAR_ntfy_channel
+      fingerprint: true
+    needs:
+      - transform
+  - id: slack
+    script: ntfy.js
+    config:
+      url: $VAR_ntfy_channel2
+      fingerprint: fingerprint:ntfy2
+    needs:
+      - transform
+  - script: slack-webhook.js
+    config:
+      webhookUrlSecret: slack_deploy_webhook
+      fingerprint: true
+      fingerprintMaxAge: 1h
+      text: $INPUT_message
+    needs:
+      - transform
+triggers:
+  - type: cron
+    schedule: 0 5 * * *

packages/server/workflows/default/registers.yaml

@@ -11,3 +11,9 @@ scripts:
   - track.yaml
   - rss-devto-to-ntfy.yaml
   - test-minio.yaml
+  - dev-joplin-sync.yaml
+  - dev-joplin-daily.yaml
+  - dev-joplin-get-note.yaml
+  - web-dave.yaml
+  - jadwal-sholat-jakart.yaml
+  - detect-example-changes.yaml

packages/server/workflows/default/web-dave.yaml

@@ -0,0 +1,14 @@
+name: Dab 0dev
+scripts:
+  - script: list-webdav.js
+    config:
+      url: https://dav.0dev.web.id/books
+      path: /
+      includeDirectories: true
+      recursive: false
+      username: nsrb
+      passwordSecret: dav_0dev_password
+triggers:
+  - type: HTTP
+    method: POST
+    path: /new

packages/web/src/App.jsx

@@ -12,6 +12,7 @@ import { WorkflowsPage } from "./pages/WorkflowsPage.jsx";
 import { WorkflowEditPage, WorkflowNewPage } from "./pages/WorkflowEditPage.jsx";
 import { EventsPage } from "./pages/EventsPage.jsx";
 import { EventDetailPage } from "./pages/EventDetailPage.jsx";
+import { FailuresPage } from "./pages/FailuresPage.jsx";
 import { KvPage } from "./pages/KvPage.jsx";
 import { AuthProfilesPage } from "./pages/AuthProfilesPage.jsx";
 import { ResponsesPage } from "./pages/ResponsesPage.jsx";
@@ -61,6 +62,7 @@ export function App() {
         <Route path="/workflows/:owner/:file/edit" element={<WorkflowEditPage />} />
         <Route path="/events" element={<EventsPage />} />
         <Route path="/events/:id" element={<EventDetailPage />} />
+        <Route path="/failures" element={<FailuresPage />} />
         <Route path="/kv" element={<KvPage />} />
         <Route path="/variables" element={<VariablesPage />} />
         <Route path="/auth" element={<AuthProfilesPage />} />

packages/web/src/api/hooks.js

@@ -266,6 +266,17 @@ export function useRuns(filters = {}) {
   });
 }
 
+export function useConsecutiveFailures(limit) {
+  return useQuery({
+    queryKey: ["consecutive-failures", limit ?? "all"],
+    queryFn: async () => {
+      const params = {};
+      if (limit) params.limit = limit;
+      return (await api.get("/consecutive-failures", { params })).data;
+    },
+  });
+}
+
 export function useRun(id) {
   return useQuery({
     queryKey: ["runs", id],

packages/web/src/components/workflow/TriggerCard.jsx

@@ -117,15 +117,15 @@ export function TriggerCard({
 
 function triggerSummary(trigger, owner) {
   const type = trigger?.type;
+  const failure =
+    trigger.onConsecutiveFailures && trigger.onFailureWorkflow
+      ? ` · onFailure@${trigger.onFailureWorkflow}`
+      : "";
   if (type === "HTTP") {
-    return `${trigger.method || "POST"} ${namespacedPath(owner || "owner", trigger.path || "/")}`;
+    return `${trigger.method || "POST"} ${namespacedPath(owner || "owner", trigger.path || "/")}${failure}`;
   }
   if (type === "cron") {
-    const extra =
+    return `${trigger.schedule || ""}${failure}`;
-      trigger.onConsecutiveFailures && trigger.triggerWorkflow
-        ? ` · alert@${trigger.triggerWorkflow}`
-        : "";
-    return `${trigger.schedule || ""}${extra}`;
   }
   if (type === "workflow") return "callable";
   return "";
@@ -320,12 +320,12 @@ function FailureAlertFields({ trigger, disabled, onChange, alertDestinations })
         />
       </label>
       <label className="form-control">
-        <span className="label py-0 text-sm">Trigger workflow</span>
+        <span className="label py-0 text-sm">On failure, start</span>
         <select
           className="select select-sm"
-          value={trigger.triggerWorkflow ?? ""}
+          value={trigger.onFailureWorkflow ?? ""}
           disabled={disabled}
-          onChange={(e) => onChange({ ...trigger, triggerWorkflow: e.target.value })}
+          onChange={(e) => onChange({ ...trigger, onFailureWorkflow: e.target.value })}
         >
           <option value="">None</option>
           {alertDestinations.map((w) => (
@@ -333,11 +333,11 @@ function FailureAlertFields({ trigger, disabled, onChange, alertDestinations })
               {w.name ?? w.file}
             </option>
           ))}
-          {trigger.triggerWorkflow &&
+          {trigger.onFailureWorkflow &&
           !alertDestinations.some(
-            (w) => (w.name ?? w.file) === trigger.triggerWorkflow,
+            (w) => (w.name ?? w.file) === trigger.onFailureWorkflow,
           ) ? (
-            <option value={trigger.triggerWorkflow}>{trigger.triggerWorkflow}</option>
+            <option value={trigger.onFailureWorkflow}>{trigger.onFailureWorkflow}</option>
           ) : null}
         </select>
       </label>

packages/web/src/lib/workflow-doc.js

@@ -143,7 +143,7 @@ export function newHttpTrigger() {
     response: "",
     unauthorized: null,
     onConsecutiveFailures: "",
-    triggerWorkflow: "",
+    onFailureWorkflow: "",
   };
 }
 
@@ -158,7 +158,7 @@ export function newCronTrigger() {
     response: "",
     unauthorized: null,
     onConsecutiveFailures: "",
-    triggerWorkflow: "",
+    onFailureWorkflow: "",
   };
 }
 
@@ -173,7 +173,7 @@ export function newWorkflowTrigger() {
     response: "",
     unauthorized: null,
     onConsecutiveFailures: "",
-    triggerWorkflow: "",
+    onFailureWorkflow: "",
   };
 }
 
@@ -191,6 +191,10 @@ export function triggerDestinations(workflows, { owner, excludeFile } = {}) {
 
 export { HTTP_METHODS };
 
+function readOnFailureWorkflow(raw) {
+  return typeof raw?.onFailureWorkflow === "string" ? raw.onFailureWorkflow : "";
+}
+
 function normalizeStep(step) {
   const uiId = nextUiId("step");
   if (typeof step === "string") {
@@ -266,10 +270,10 @@ function normalizeTrigger(raw) {
           "response",
           "unauthorized",
           "onConsecutiveFailures",
-          "triggerWorkflow",
+          "onFailureWorkflow",
         ])
       : type === "cron"
-        ? new Set(["type", "schedule", "onConsecutiveFailures", "triggerWorkflow"])
+        ? new Set(["type", "schedule", "onConsecutiveFailures", "onFailureWorkflow"])
         : new Set(["type"]);
   /** @type {Record<string, unknown>} */
   const extra = {};
@@ -286,8 +290,7 @@ function normalizeTrigger(raw) {
       raw.onConsecutiveFailures == null || raw.onConsecutiveFailures === ""
         ? ""
         : String(raw.onConsecutiveFailures),
-    triggerWorkflow:
+    onFailureWorkflow: readOnFailureWorkflow(raw),
-      typeof raw.triggerWorkflow === "string" ? raw.triggerWorkflow : "",
     auth: raw.auth ?? null,
     response: typeof raw.response === "string" ? raw.response : "",
     unauthorized: raw.unauthorized ?? null,
@@ -328,8 +331,8 @@ function dumpFailureTriggerFields(t, out) {
       out.onConsecutiveFailures = Math.floor(threshold);
     }
   }
-  if (typeof t.triggerWorkflow === "string" && t.triggerWorkflow.trim()) {
+  if (typeof t.onFailureWorkflow === "string" && t.onFailureWorkflow.trim()) {
-    out.triggerWorkflow = t.triggerWorkflow.trim();
+    out.onFailureWorkflow = t.onFailureWorkflow.trim();
   }
 }
 

packages/web/src/pages/EventsPage.jsx

@@ -21,7 +21,7 @@ export function EventsPage() {
 
   return (
     <div className="space-y-4">
-      <h1 className="text-xl font-semibold">Events</h1>
+      <h1 className="text-xl font-semibold">{status === "failed" ? "Failed events" : "Events"}</h1>
       <div className="flex flex-col sm:flex-row gap-2">
         <input
           className="input input-sm w-full sm:max-w-sm"

packages/web/src/pages/FailuresPage.jsx

@@ -0,0 +1,63 @@
+import { Link } from "react-router-dom";
+import { useConsecutiveFailures } from "../api/hooks.js";
+import { formatTime } from "../lib/format.jsx";
+
+export function FailuresPage() {
+  const { data, isLoading, error } = useConsecutiveFailures();
+  const items = data?.items ?? [];
+
+  return (
+    <div className="space-y-4">
+      <h1 className="text-xl font-semibold">Failures</h1>
+      <p className="opacity-70 text-sm">
+        Workflows that have failed 4 or more times in a row for the same trigger.
+      </p>
+      {isLoading ? (
+        <span className="loading loading-spinner" />
+      ) : error ? (
+        <p className="text-error">Failed to load consecutive failures</p>
+      ) : items.length === 0 ? (
+        <p className="opacity-60 text-sm">None</p>
+      ) : (
+        <div className="overflow-x-auto">
+          <table className="table table-sm">
+            <thead>
+              <tr>
+                <th>Streak</th>
+                <th>Workflow</th>
+                <th>Trigger</th>
+                <th>Last error</th>
+                <th>Last failed</th>
+              </tr>
+            </thead>
+            <tbody>
+              {items.map((s) => (
+                <tr
+                  key={`${s.workflow}\0${s.trigger_type}\0${s.trigger_detail ?? ""}`}
+                  className="hover"
+                >
+                  <td>
+                    <span className="badge badge-error badge-sm">{s.consecutiveFailures}</span>
+                  </td>
+                  <td>
+                    <Link className="link" to={`/events/${s.lastRun.id}`}>
+                      {s.workflow_name || s.workflow}
+                    </Link>
+                  </td>
+                  <td className="text-xs">
+                    {s.trigger_type}
+                    {s.trigger_detail ? ` · ${s.trigger_detail}` : ""}
+                  </td>
+                  <td className="max-w-md truncate text-xs" title={s.lastRun.error ?? ""}>
+                    {s.lastRun.error || "—"}
+                  </td>
+                  <td className="whitespace-nowrap">{formatTime(s.lastRun.started_at)}</td>
+                </tr>
+              ))}
+            </tbody>
+          </table>
+        </div>
+      )}
+    </div>
+  );
+}

packages/web/src/pages/HomePage.jsx

@@ -1,10 +1,5 @@
 import { Link } from "react-router-dom";
-import {
+import { LuCode, LuGitBranch, LuTriangleAlert } from "react-icons/lu";
-  LuActivity,
-  LuCode,
-  LuGitBranch,
-  LuTriangleAlert,
-} from "react-icons/lu";
 import { useDashboard } from "../api/hooks.js";
 import { formatTime, StatusBadge } from "../lib/format.jsx";
 
@@ -18,8 +13,10 @@ export function HomePage() {
     return <p className="text-error">Failed to load dashboard</p>;
   }
 
-  const failed = data.needsAttention?.failed ?? [];
+  const streaks = data.needsAttention?.consecutiveFailures ?? [];
+  const streakCount = data.needsAttention?.consecutiveFailureCount ?? streaks.length;
   const broken = data.needsAttention?.brokenWorkflows ?? [];
+  const failedEvents = data.failedEvents ?? [];
 
   return (
     <div className="space-y-6">
@@ -39,31 +36,23 @@ export function HomePage() {
           <div className="stat-title">Scripts</div>
           <div className="stat-value text-2xl">{data.scriptCount}</div>
         </div>
-        <div className="stat">
-          <div className="stat-figure text-warning">
-            <LuActivity className="size-7" />
-          </div>
-          <div className="stat-title">Running</div>
-          <div className="stat-value text-2xl">{data.running?.length ?? 0}</div>
-        </div>
         <div className="stat">
           <div className="stat-figure text-error">
             <LuTriangleAlert className="size-7" />
           </div>
           <div className="stat-title">Attention</div>
-          <div className="stat-value text-2xl">
+          <div className="stat-value text-2xl">{streakCount + broken.length}</div>
-            {failed.length + broken.length}
-          </div>
         </div>
       </div>
 
-      <section>
+      <div className="grid grid-cols-1 gap-6 lg:grid-cols-3">
-        <h2 className="text-lg font-semibold mb-2">Running</h2>
+        <section className="min-w-0">
-        <RunList runs={data.running} empty="None" />
+          <div className="mb-2 flex items-baseline justify-between gap-2">
-      </section>
+            <h2 className="text-lg font-semibold">Needs attention</h2>
-
+            <Link className="link link-hover text-sm" to="/failures">
-      <section>
+              Show all
-        <h2 className="text-lg font-semibold mb-2">Needs attention</h2>
+            </Link>
+          </div>
           {broken.length > 0 ? (
             <ul className="mb-3 space-y-1">
               {broken.map((w) => (
@@ -78,14 +67,59 @@ export function HomePage() {
               ))}
             </ul>
           ) : null}
-        <RunList runs={failed} empty={broken.length ? "" : "None"} />
+          <StreakList streaks={streaks} empty={broken.length ? "" : "None"} />
         </section>
 
-      <section>
+        <section className="min-w-0">
+          <div className="mb-2 flex items-baseline justify-between gap-2">
+            <h2 className="text-lg font-semibold">Failed events</h2>
+            <Link className="link link-hover text-sm" to="/events?status=failed">
+              View all
+            </Link>
+          </div>
+          <RunList runs={failedEvents} empty="None" />
+        </section>
+
+        <section className="min-w-0">
           <h2 className="text-lg font-semibold mb-2">Recent</h2>
           <RunList runs={data.recent} empty="None" />
         </section>
       </div>
+    </div>
+  );
+}
+
+function StreakList({ streaks, empty }) {
+  if (!streaks?.length) {
+    return empty ? <p className="opacity-60 text-sm">{empty}</p> : null;
+  }
+  return (
+    <div className="overflow-x-auto">
+      <table className="table table-sm">
+        <thead>
+          <tr>
+            <th>Streak</th>
+            <th>Workflow</th>
+            <th>Last failed</th>
+          </tr>
+        </thead>
+        <tbody>
+          {streaks.map((s) => (
+            <tr key={`${s.workflow}\0${s.trigger_type}\0${s.trigger_detail ?? ""}`} className="hover">
+              <td>
+                <span className="badge badge-error badge-sm">{s.consecutiveFailures}</span>
+              </td>
+              <td>
+                <Link className="link" to={`/events/${s.lastRun.id}`}>
+                  {s.workflow_name || s.workflow}
+                </Link>
+              </td>
+              <td className="whitespace-nowrap">{formatTime(s.lastRun.started_at)}</td>
+            </tr>
+          ))}
+        </tbody>
+      </table>
+    </div>
   );
 }