refactor(web): shared ConfirmDialog, FormControls, and Modal a11y

Extract reusable confirm/modal shells and bordered form controls, adopt them across list pages and editors, and improve icon-button labels plus KvPage keyboard rows.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
2026-08-21 22:08:23 +07:00
co-authored by Cursor
parent 9985ff3440
commit 3d25d8a614
27 changed files with 606 additions and 626 deletions
+24 -23
View File
@@ -6,6 +6,7 @@ import {
useHttpPages, useHttpPages,
useUpsertHttpAuth, useUpsertHttpAuth,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { FormInput, FormSelect } from "./FormControls.jsx";
function emptyCred(source = "literal") { function emptyCred(source = "literal") {
return { source, value: "", kv: "", namespace: "", secret: "" }; return { source, value: "", kv: "", namespace: "", secret: "" };
@@ -120,15 +121,15 @@ function CredentialFields({ label, cred, onChange, allowEmpty, masked }) {
<div className="space-y-3 rounded-box border border-base-300 p-3"> <div className="space-y-3 rounded-box border border-base-300 p-3">
<p className="text-sm font-medium">{label}</p> <p className="text-sm font-medium">{label}</p>
<Field label="Source"> <Field label="Source">
<select <FormSelect
className="select select-bordered w-full" className="w-full"
value={cred.source} value={cred.source}
onChange={(e) => onChange({ ...cred, source: e.target.value, keep: false })} onChange={(e) => onChange({ ...cred, source: e.target.value, keep: false })}
> >
<option value="literal">Plain text</option> <option value="literal">Plain text</option>
<option value="kv">From KV</option> <option value="kv">From KV</option>
<option value="secret">From secret</option> <option value="secret">From secret</option>
</select> </FormSelect>
</Field> </Field>
{cred.source === "literal" ? ( {cred.source === "literal" ? (
<Field <Field
@@ -140,9 +141,9 @@ function CredentialFields({ label, cred, onChange, allowEmpty, masked }) {
} }
> >
<div className="flex w-full gap-1"> <div className="flex w-full gap-1">
<input <FormInput
type={masked && !show ? "password" : "text"} type={masked && !show ? "password" : "text"}
className="input input-bordered w-full font-mono" className="w-full font-mono"
value={cred.value} value={cred.value}
onChange={(e) => onChange({ ...cred, value: e.target.value, keep: false })} onChange={(e) => onChange({ ...cred, value: e.target.value, keep: false })}
placeholder={ placeholder={
@@ -168,16 +169,16 @@ function CredentialFields({ label, cred, onChange, allowEmpty, masked }) {
{cred.source === "kv" ? ( {cred.source === "kv" ? (
<> <>
<Field label="Namespace (optional)"> <Field label="Namespace (optional)">
<input <FormInput
className="input input-bordered w-full font-mono" className="w-full font-mono"
placeholder="namespace" placeholder="namespace"
value={cred.namespace} value={cred.namespace}
onChange={(e) => onChange({ ...cred, namespace: e.target.value })} onChange={(e) => onChange({ ...cred, namespace: e.target.value })}
/> />
</Field> </Field>
<Field label="Key"> <Field label="Key">
<input <FormInput
className="input input-bordered w-full font-mono" className="w-full font-mono"
placeholder="key" placeholder="key"
value={cred.kv} value={cred.kv}
onChange={(e) => onChange({ ...cred, kv: e.target.value })} onChange={(e) => onChange({ ...cred, kv: e.target.value })}
@@ -191,8 +192,8 @@ function CredentialFields({ label, cred, onChange, allowEmpty, masked }) {
label="Secret name" label="Secret name"
hint="Encrypted secret — value is never shown here. Manage it on the Secrets page." hint="Encrypted secret — value is never shown here. Manage it on the Secrets page."
> >
<input <FormInput
className="input input-bordered w-full font-mono" className="w-full font-mono"
placeholder="secret name" placeholder="secret name"
value={cred.secret} value={cred.secret}
onChange={(e) => onChange({ ...cred, secret: e.target.value })} onChange={(e) => onChange({ ...cred, secret: e.target.value })}
@@ -297,8 +298,8 @@ export function AuthEditorModal({ mode, auth, onClose, onSaved }) {
) : ( ) : (
<form className="mt-3 space-y-4" onSubmit={onSubmit}> <form className="mt-3 space-y-4" onSubmit={onSubmit}>
<Field label="Name"> <Field label="Name">
<input <FormInput
className="input input-bordered w-full font-mono" className="w-full font-mono"
value={form.name} value={form.name}
onChange={(e) => setForm({ ...form, name: e.target.value })} onChange={(e) => setForm({ ...form, name: e.target.value })}
required required
@@ -308,15 +309,15 @@ export function AuthEditorModal({ mode, auth, onClose, onSaved }) {
</Field> </Field>
<Field label="Type"> <Field label="Type">
<select <FormSelect
className="select select-bordered w-full" className="w-full"
value={form.type} value={form.type}
onChange={(e) => setForm({ ...form, type: e.target.value })} onChange={(e) => setForm({ ...form, type: e.target.value })}
> >
<option value="bearer">bearer</option> <option value="bearer">bearer</option>
<option value="basic">basic</option> <option value="basic">basic</option>
<option value="header">header</option> <option value="header">header</option>
</select> </FormSelect>
</Field> </Field>
{form.type === "bearer" ? ( {form.type === "bearer" ? (
@@ -345,8 +346,8 @@ export function AuthEditorModal({ mode, auth, onClose, onSaved }) {
{form.type === "header" ? ( {form.type === "header" ? (
<> <>
<Field label="Header name"> <Field label="Header name">
<input <FormInput
className="input input-bordered w-full font-mono" className="w-full font-mono"
value={form.header} value={form.header}
onChange={(e) => setForm({ ...form, header: e.target.value })} onChange={(e) => setForm({ ...form, header: e.target.value })}
required required
@@ -362,9 +363,9 @@ export function AuthEditorModal({ mode, auth, onClose, onSaved }) {
) : null} ) : null}
<Field label="Unauthorized status (optional)"> <Field label="Unauthorized status (optional)">
<input <FormInput
type="number" type="number"
className="input input-bordered w-full" className="w-full"
value={form.unauthorized_status} value={form.unauthorized_status}
onChange={(e) => setForm({ ...form, unauthorized_status: e.target.value })} onChange={(e) => setForm({ ...form, unauthorized_status: e.target.value })}
min={100} min={100}
@@ -374,8 +375,8 @@ export function AuthEditorModal({ mode, auth, onClose, onSaved }) {
</Field> </Field>
<Field label="Unauthorized response page (optional)"> <Field label="Unauthorized response page (optional)">
<select <FormSelect
className="select select-bordered w-full" className="w-full"
value={form.unauthorized_response} value={form.unauthorized_response}
onChange={(e) => setForm({ ...form, unauthorized_response: e.target.value })} onChange={(e) => setForm({ ...form, unauthorized_response: e.target.value })}
> >
@@ -385,7 +386,7 @@ export function AuthEditorModal({ mode, auth, onClose, onSaved }) {
{p.name} {p.name}
</option> </option>
))} ))}
</select> </FormSelect>
</Field> </Field>
{upsert.isError ? ( {upsert.isError ? (
@@ -0,0 +1,55 @@
import { Modal } from "./Modal.jsx";
/**
* Shared confirm / delete dialog.
*
* @param {object} props
* @param {boolean} props.open
* @param {string} props.title
* @param {import("react").ReactNode} [props.message]
* @param {string} [props.confirmLabel]
* @param {string} [props.confirmClass]
* @param {boolean} [props.loading]
* @param {boolean} [props.pending] alias for loading
* @param {boolean} [props.confirmDisabled]
* @param {import("react").ReactNode} [props.error]
* @param {() => void} props.onCancel
* @param {() => void} props.onConfirm
*/
export function ConfirmDialog({
open,
title,
message,
confirmLabel = "Delete",
confirmClass = "btn-error",
loading,
pending,
confirmDisabled = false,
error,
onCancel,
onConfirm,
}) {
const busy = Boolean(loading ?? pending);
return (
<Modal open={open} onClose={onCancel} boxClassName="max-w-md" aria-label={title}>
<h3 className="font-bold">{title}</h3>
{message ? <div className="mt-2 text-sm opacity-70">{message}</div> : null}
{error ? <p className="text-error text-sm mt-2">{error}</p> : null}
<div className="modal-action">
<button type="button" className="btn btn-ghost" onClick={onCancel} disabled={busy}>
Cancel
</button>
<button
type="button"
className={`btn ${confirmClass}`}
disabled={busy || confirmDisabled}
onClick={onConfirm}
>
{busy ? <span className="loading loading-spinner loading-xs" /> : null}
{confirmLabel}
</button>
</div>
</Modal>
);
}
@@ -0,0 +1,27 @@
/**
* Shared DaisyUI form controls — always bordered + sm.
*/
import { forwardRef } from "react";
export const FormInput = forwardRef(function FormInput({ className = "", ...props }, ref) {
return <input ref={ref} className={`input input-bordered input-sm ${className}`.trim()} {...props} />;
});
export const FormSelect = forwardRef(function FormSelect({ className = "", children, ...props }, ref) {
return (
<select ref={ref} className={`select select-bordered select-sm ${className}`.trim()} {...props}>
{children}
</select>
);
});
export const FormTextarea = forwardRef(function FormTextarea({ className = "", ...props }, ref) {
return (
<textarea
ref={ref}
className={`textarea textarea-bordered textarea-sm ${className}`.trim()}
{...props}
/>
);
});
+85
View File
@@ -0,0 +1,85 @@
import { useEffect, useId, useRef } from "react";
/**
* DaisyUI modal shell with Escape, labeled backdrop close, and a light focus trap.
*
* @param {object} props
* @param {boolean} props.open
* @param {() => void} props.onClose
* @param {import("react").ReactNode} props.children
* @param {string} [props.boxClassName]
* @param {string} [props["aria-labelledby"]]
* @param {string} [props["aria-label"]]
*/
export function Modal({
open,
onClose,
children,
boxClassName = "",
"aria-labelledby": ariaLabelledBy,
"aria-label": ariaLabel,
}) {
const boxRef = useRef(/** @type {HTMLDivElement | null} */ (null));
const fallbackId = useId();
const labelledBy = ariaLabelledBy || (ariaLabel ? undefined : fallbackId);
useEffect(() => {
if (!open) return undefined;
const box = boxRef.current;
const previous = /** @type {HTMLElement | null} */ (document.activeElement);
function focusables() {
if (!box) return [];
return [
...box.querySelectorAll(
'button:not([disabled]), [href], input:not([disabled]), select:not([disabled]), textarea:not([disabled]), [tabindex]:not([tabindex="-1"])',
),
].filter((el) => el instanceof HTMLElement && !el.hasAttribute("disabled"));
}
const first = focusables()[0];
first?.focus();
function onKeyDown(e) {
if (e.key === "Escape") {
e.preventDefault();
onClose();
return;
}
if (e.key !== "Tab" || !box) return;
const items = focusables();
if (items.length === 0) return;
const firstEl = items[0];
const lastEl = items[items.length - 1];
if (e.shiftKey && document.activeElement === firstEl) {
e.preventDefault();
lastEl.focus();
} else if (!e.shiftKey && document.activeElement === lastEl) {
e.preventDefault();
firstEl.focus();
}
}
document.addEventListener("keydown", onKeyDown);
return () => {
document.removeEventListener("keydown", onKeyDown);
previous?.focus?.();
};
}, [open, onClose]);
if (!open) return null;
return (
<dialog className="modal modal-open" aria-modal="true" aria-labelledby={labelledBy} aria-label={ariaLabel}>
<div ref={boxRef} className={`modal-box ${boxClassName}`.trim()} id={ariaLabelledBy ? undefined : fallbackId}>
{children}
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" aria-label="Close dialog" onClick={onClose}>
close
</button>
</form>
</dialog>
);
}
@@ -1,6 +1,7 @@
import { useState } from "react"; import { useState } from "react";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useOwners, useScripts, useUpsertProfile } from "../api/hooks.js"; import { useOwners, useScripts, useUpsertProfile } from "../api/hooks.js";
import { FormInput, FormSelect } from "./FormControls.jsx";
import { ConfigFields } from "./workflow/ConfigFields.jsx"; import { ConfigFields } from "./workflow/ConfigFields.jsx";
/** /**
@@ -83,8 +84,8 @@ export function ProfileEditorModal({ mode, initial, onClose, onSaved, usageCount
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Owner</span> <span className="label py-0 text-sm">Owner</span>
{owners.length > 0 ? ( {owners.length > 0 ? (
<select <FormSelect
className="select w-full" className="w-full"
value={form.owner} value={form.owner}
onChange={(e) => setForm({ ...form, owner: e.target.value })} onChange={(e) => setForm({ ...form, owner: e.target.value })}
required required
@@ -94,10 +95,10 @@ export function ProfileEditorModal({ mode, initial, onClose, onSaved, usageCount
{o} {o}
</option> </option>
))} ))}
</select> </FormSelect>
) : ( ) : (
<input <FormInput
className="input w-full" className="w-full"
value={form.owner} value={form.owner}
onChange={(e) => setForm({ ...form, owner: e.target.value })} onChange={(e) => setForm({ ...form, owner: e.target.value })}
required required
@@ -106,8 +107,8 @@ export function ProfileEditorModal({ mode, initial, onClose, onSaved, usageCount
</label> </label>
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Name</span> <span className="label py-0 text-sm">Name</span>
<input <FormInput
className="input w-full font-mono" className="w-full font-mono"
value={form.name} value={form.name}
onChange={(e) => setForm({ ...form, name: e.target.value })} onChange={(e) => setForm({ ...form, name: e.target.value })}
required required
@@ -127,8 +128,8 @@ export function ProfileEditorModal({ mode, initial, onClose, onSaved, usageCount
)} )}
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Script</span> <span className="label py-0 text-sm">Script</span>
<select <FormSelect
className="select w-full font-mono" className="w-full font-mono"
value={form.script} value={form.script}
onChange={(e) => { onChange={(e) => {
setForm({ ...form, script: e.target.value }); setForm({ ...form, script: e.target.value });
@@ -148,7 +149,7 @@ export function ProfileEditorModal({ mode, initial, onClose, onSaved, usageCount
{form.script && !scripts.some((s) => (typeof s === "string" ? s : s.name) === form.script) ? ( {form.script && !scripts.some((s) => (typeof s === "string" ? s : s.name) === form.script) ? (
<option value={form.script}>{form.script}</option> <option value={form.script}>{form.script}</option>
) : null} ) : null}
</select> </FormSelect>
</label> </label>
{scriptChanged && usageCount > 0 ? ( {scriptChanged && usageCount > 0 ? (
<p className="text-warning text-sm"> <p className="text-warning text-sm">
@@ -159,8 +160,8 @@ export function ProfileEditorModal({ mode, initial, onClose, onSaved, usageCount
) : null} ) : null}
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Description</span> <span className="label py-0 text-sm">Description</span>
<input <FormInput
className="input w-full" className="w-full"
value={form.description} value={form.description}
onChange={(e) => setForm({ ...form, description: e.target.value })} onChange={(e) => setForm({ ...form, description: e.target.value })}
maxLength={500} maxLength={500}
@@ -1,6 +1,8 @@
import { useState } from "react"; import { useState } from "react";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useOwners, useUpsertSecret } from "../api/hooks.js"; import { useOwners, useUpsertSecret } from "../api/hooks.js";
import { FormInput, FormSelect } from "./FormControls.jsx";
import { Modal } from "./Modal.jsx";
/** /**
* Add / replace an encrypted secret. * Add / replace an encrypted secret.
@@ -43,85 +45,78 @@ export function SecretEditorModal({
const title = mode === "add" ? "New secret" : `Replace ${form.owner}/${form.name}`; const title = mode === "add" ? "New secret" : `Replace ${form.owner}/${form.name}`;
return ( return (
<dialog className="modal modal-open"> <Modal open onClose={onClose} boxClassName="max-w-md" aria-label={title}>
<div className="modal-box max-w-md"> <h3 className="font-bold">{title}</h3>
<h3 className="font-bold">{title}</h3> <form className="mt-3 space-y-2" onSubmit={onSubmit}>
<form className="mt-3 space-y-2" onSubmit={onSubmit}> {mode === "add" ? (
{mode === "add" ? ( <>
<> <label className="form-control w-full">
<label className="form-control w-full"> <span className="label py-0 text-sm">Owner</span>
<span className="label py-0 text-sm">Owner</span> {owners.length > 0 ? (
{owners.length > 0 ? ( <FormSelect
<select className="w-full"
className="select w-full" value={form.owner}
value={form.owner} onChange={(e) => setForm({ ...form, owner: e.target.value })}
onChange={(e) => setForm({ ...form, owner: e.target.value })}
required
disabled={lockOwner}
>
{owners.map((o) => (
<option key={o} value={o}>
{o}
</option>
))}
</select>
) : (
<input
className="input w-full"
value={form.owner}
onChange={(e) => setForm({ ...form, owner: e.target.value })}
required
disabled={lockOwner}
/>
)}
</label>
<label className="form-control w-full">
<span className="label py-0 text-sm">Name</span>
<input
className="input w-full font-mono"
value={form.name}
onChange={(e) => setForm({ ...form, name: e.target.value })}
required required
pattern="[A-Za-z0-9._-]+" disabled={lockOwner}
title="Letters, numbers, dots, underscores, hyphens" >
{owners.map((o) => (
<option key={o} value={o}>
{o}
</option>
))}
</FormSelect>
) : (
<FormInput
className="w-full"
value={form.owner}
onChange={(e) => setForm({ ...form, owner: e.target.value })}
required
disabled={lockOwner}
/> />
</label> )}
</> </label>
) : null} <label className="form-control w-full">
<label className="form-control w-full"> <span className="label py-0 text-sm">Name</span>
<span className="label py-0 text-sm">Value</span> <FormInput
<input className="w-full font-mono"
type="password" value={form.name}
className="input w-full" onChange={(e) => setForm({ ...form, name: e.target.value })}
value={form.value} required
onChange={(e) => setForm({ ...form, value: e.target.value })} pattern="[A-Za-z0-9._-]+"
required title="Letters, numbers, dots, underscores, hyphens"
autoComplete="new-password" />
/> </label>
</label> </>
<p className="text-xs opacity-60"> ) : null}
Values are encrypted at rest and never shown again after save. Values shorter than 8 <label className="form-control w-full">
characters are not redacted from logs. <span className="label py-0 text-sm">Value</span>
</p> <FormInput
{upsert.isError ? ( type="password"
<p className="text-error text-sm">{errorMessage(upsert.error)}</p> className="w-full"
) : null} value={form.value}
<div className="modal-action"> onChange={(e) => setForm({ ...form, value: e.target.value })}
<button type="button" className="btn btn-ghost" onClick={onClose}> required
Cancel autoComplete="new-password"
</button> />
<button type="submit" className="btn btn-primary" disabled={upsert.isPending}> </label>
{upsert.isPending ? <span className="loading loading-spinner loading-xs" /> : null} <p className="text-xs opacity-60">
Save Values are encrypted at rest and never shown again after save. Values shorter than 8
</button> characters are not redacted from logs.
</div> </p>
</form> {upsert.isError ? (
</div> <p className="text-error text-sm">{errorMessage(upsert.error)}</p>
<form method="dialog" className="modal-backdrop"> ) : null}
<button type="button" onClick={onClose}> <div className="modal-action">
close <button type="button" className="btn btn-ghost" onClick={onClose}>
</button> Cancel
</button>
<button type="submit" className="btn btn-primary" disabled={upsert.isPending}>
{upsert.isPending ? <span className="loading loading-spinner loading-xs" /> : null}
Save
</button>
</div>
</form> </form>
</dialog> </Modal>
); );
} }
@@ -1,6 +1,7 @@
import { useState } from "react"; import { useState } from "react";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useCreateUser, useUpdateUser } from "../api/hooks.js"; import { useCreateUser, useUpdateUser } from "../api/hooks.js";
import { FormInput, FormSelect } from "./FormControls.jsx";
/** /**
* Add / edit a local user. * Add / edit a local user.
@@ -61,8 +62,8 @@ export function UserEditorModal({ mode, user, onClose, onSaved }) {
{mode === "add" ? ( {mode === "add" ? (
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Username</span> <span className="label py-0 text-sm">Username</span>
<input <FormInput
className="input w-full" className="w-full"
value={form.username} value={form.username}
onChange={(e) => setForm({ ...form, username: e.target.value })} onChange={(e) => setForm({ ...form, username: e.target.value })}
required required
@@ -73,9 +74,9 @@ export function UserEditorModal({ mode, user, onClose, onSaved }) {
<span className="label py-0 text-sm"> <span className="label py-0 text-sm">
{mode === "add" ? "Password" : "New password"} {mode === "add" ? "Password" : "New password"}
</span> </span>
<input <FormInput
type="password" type="password"
className="input w-full" className="w-full"
value={form.password} value={form.password}
onChange={(e) => setForm({ ...form, password: e.target.value })} onChange={(e) => setForm({ ...form, password: e.target.value })}
required={mode === "add"} required={mode === "add"}
@@ -85,14 +86,14 @@ export function UserEditorModal({ mode, user, onClose, onSaved }) {
</label> </label>
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Role</span> <span className="label py-0 text-sm">Role</span>
<select <FormSelect
className="select w-full" className="w-full"
value={form.role} value={form.role}
onChange={(e) => setForm({ ...form, role: e.target.value })} onChange={(e) => setForm({ ...form, role: e.target.value })}
> >
<option value="operator">operator</option> <option value="operator">operator</option>
<option value="admin">admin</option> <option value="admin">admin</option>
</select> </FormSelect>
</label> </label>
{mutation.isError ? ( {mutation.isError ? (
<p className="text-error text-sm">{errorMessage(mutation.error)}</p> <p className="text-error text-sm">{errorMessage(mutation.error)}</p>
@@ -1,6 +1,7 @@
import { useState } from "react"; import { useState } from "react";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useOwners, useUpsertVariable } from "../api/hooks.js"; import { useOwners, useUpsertVariable } from "../api/hooks.js";
import { FormInput, FormSelect, FormTextarea } from "./FormControls.jsx";
const TYPES = ["string", "number", "boolean"]; const TYPES = ["string", "number", "boolean"];
@@ -83,8 +84,8 @@ export function VariableEditorModal({
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Owner</span> <span className="label py-0 text-sm">Owner</span>
{owners.length > 0 ? ( {owners.length > 0 ? (
<select <FormSelect
className="select w-full" className="w-full"
value={form.owner} value={form.owner}
onChange={(e) => setForm({ ...form, owner: e.target.value })} onChange={(e) => setForm({ ...form, owner: e.target.value })}
required required
@@ -95,10 +96,10 @@ export function VariableEditorModal({
{o} {o}
</option> </option>
))} ))}
</select> </FormSelect>
) : ( ) : (
<input <FormInput
className="input w-full" className="w-full"
value={form.owner} value={form.owner}
onChange={(e) => setForm({ ...form, owner: e.target.value })} onChange={(e) => setForm({ ...form, owner: e.target.value })}
required required
@@ -108,8 +109,8 @@ export function VariableEditorModal({
</label> </label>
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Name</span> <span className="label py-0 text-sm">Name</span>
<input <FormInput
className="input w-full font-mono" className="w-full font-mono"
value={form.name} value={form.name}
onChange={(e) => setForm({ ...form, name: e.target.value })} onChange={(e) => setForm({ ...form, name: e.target.value })}
required required
@@ -121,8 +122,8 @@ export function VariableEditorModal({
) : null} ) : null}
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Type</span> <span className="label py-0 text-sm">Type</span>
<select <FormSelect
className="select w-full" className="w-full"
value={form.type} value={form.type}
onChange={(e) => onTypeChange(e.target.value)} onChange={(e) => onTypeChange(e.target.value)}
> >
@@ -131,31 +132,31 @@ export function VariableEditorModal({
{t} {t}
</option> </option>
))} ))}
</select> </FormSelect>
</label> </label>
<label className="form-control w-full"> <label className="form-control w-full">
<span className="label py-0 text-sm">Value</span> <span className="label py-0 text-sm">Value</span>
{form.type === "boolean" ? ( {form.type === "boolean" ? (
<select <FormSelect
className="select w-full" className="w-full"
value={form.value === true ? "true" : "false"} value={form.value === true ? "true" : "false"}
onChange={(e) => setForm({ ...form, value: e.target.value === "true" })} onChange={(e) => setForm({ ...form, value: e.target.value === "true" })}
> >
<option value="true">true</option> <option value="true">true</option>
<option value="false">false</option> <option value="false">false</option>
</select> </FormSelect>
) : form.type === "number" ? ( ) : form.type === "number" ? (
<input <FormInput
type="number" type="number"
className="input w-full font-mono" className="w-full font-mono"
value={form.value} value={form.value}
onChange={(e) => setForm({ ...form, value: e.target.value })} onChange={(e) => setForm({ ...form, value: e.target.value })}
required required
step="any" step="any"
/> />
) : ( ) : (
<textarea <FormTextarea
className="textarea w-full font-mono min-h-24" className="w-full font-mono min-h-24"
value={form.value} value={form.value}
onChange={(e) => setForm({ ...form, value: e.target.value })} onChange={(e) => setForm({ ...form, value: e.target.value })}
spellCheck={false} spellCheck={false}
@@ -1,5 +1,6 @@
import { useMemo, useState } from "react"; import { useMemo, useState } from "react";
import { useProfiles, useScripts } from "../../api/hooks.js"; import { useProfiles, useScripts } from "../../api/hooks.js";
import { FormInput } from "../FormControls.jsx";
import { ScriptIcon } from "../ScriptIcon.jsx"; import { ScriptIcon } from "../ScriptIcon.jsx";
import { scriptTags } from "../../lib/script.js"; import { scriptTags } from "../../lib/script.js";
@@ -66,8 +67,8 @@ export function AddScriptDialog({ open, onClose, onPick, owner }) {
Profiles Profiles
</button> </button>
</div> </div>
<input <FormInput
className="input input-sm w-full mt-3" className="w-full mt-3"
placeholder={tab === "profiles" ? "Search profiles" : "Search scripts"} placeholder={tab === "profiles" ? "Search profiles" : "Search scripts"}
value={q} value={q}
onChange={(e) => setQ(e.target.value)} onChange={(e) => setQ(e.target.value)}
@@ -4,6 +4,7 @@ import { LuEye, LuEyeOff, LuExternalLink, LuPlus, LuTrash2 } from "react-icons/l
import { useVariables } from "../../api/hooks.js"; import { useVariables } from "../../api/hooks.js";
import { triggerDestinations } from "../../lib/workflow-doc.js"; import { triggerDestinations } from "../../lib/workflow-doc.js";
import { prettyJson } from "../../lib/script.js"; import { prettyJson } from "../../lib/script.js";
import { FormInput, FormSelect, FormTextarea } from "../FormControls.jsx";
import { FieldLabel } from "./FieldHelp.jsx"; import { FieldLabel } from "./FieldHelp.jsx";
const MULTILINE_KEYS = new Set(["expression", "jsonata"]); const MULTILINE_KEYS = new Set(["expression", "jsonata"]);
@@ -197,8 +198,8 @@ function EditableText({ value, onCommit, className = "", placeholder = "…", di
} }
return ( return (
<input <FormInput
className={`input input-sm w-full ${className}`} className={`w-full ${className}`.trim()}
value={draft} value={draft}
autoFocus autoFocus
onChange={(e) => setDraft(e.target.value)} onChange={(e) => setDraft(e.target.value)}
@@ -239,8 +240,8 @@ function ValueEditor({ value, onChange, spec, script, fieldKey, workflows, owner
const current = value === undefined || value === null ? fallback : value; const current = value === undefined || value === null ? fallback : value;
const known = options.some((o) => o.value === current); const known = options.some((o) => o.value === current);
return ( return (
<select <FormSelect
className="select select-sm w-full" className="w-full"
value={current === undefined || current === null ? "" : String(current)} value={current === undefined || current === null ? "" : String(current)}
onChange={(e) => { onChange={(e) => {
const next = e.target.value; const next = e.target.value;
@@ -262,7 +263,7 @@ function ValueEditor({ value, onChange, spec, script, fieldKey, workflows, owner
{known || current === "" || current == null ? null : ( {known || current === "" || current == null ? null : (
<option value={String(current)}>{String(current)}</option> <option value={String(current)}>{String(current)}</option>
)} )}
</select> </FormSelect>
); );
} }
@@ -280,9 +281,9 @@ function ValueEditor({ value, onChange, spec, script, fieldKey, workflows, owner
if (type === "number") { if (type === "number") {
return ( return (
<input <FormInput
type="number" type="number"
className="input input-sm w-full" className="w-full"
value={value ?? ""} value={value ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => { onChange={(e) => {
@@ -329,8 +330,8 @@ function ValueEditor({ value, onChange, spec, script, fieldKey, workflows, owner
const multiline = MULTILINE_KEYS.has(fieldKey) || str.includes("\n"); const multiline = MULTILINE_KEYS.has(fieldKey) || str.includes("\n");
if (multiline) { if (multiline) {
return ( return (
<textarea <FormTextarea
className="textarea textarea-sm w-full min-h-24 font-mono text-xs" className="w-full min-h-24 font-mono text-xs"
value={str} value={str}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange(e.target.value)} onChange={(e) => onChange(e.target.value)}
@@ -347,8 +348,8 @@ function JsonOrTextArea({ text, onCommit, disabled }) {
setDraft(text); setDraft(text);
}, [text]); }, [text]);
return ( return (
<textarea <FormTextarea
className="textarea textarea-sm w-full min-h-24 font-mono text-xs" className="w-full min-h-24 font-mono text-xs"
value={draft} value={draft}
disabled={disabled} disabled={disabled}
onChange={(e) => setDraft(e.target.value)} onChange={(e) => setDraft(e.target.value)}
@@ -441,8 +442,8 @@ function WorkflowNamePicker({ value, onChange, workflows, owner, excludeFile, di
return ( return (
<div className="space-y-1"> <div className="space-y-1">
<select <FormSelect
className="select select-sm w-full" className="w-full"
value={selectValue} value={selectValue}
disabled={disabled} disabled={disabled}
onChange={(e) => { onChange={(e) => {
@@ -464,10 +465,10 @@ function WorkflowNamePicker({ value, onChange, workflows, owner, excludeFile, di
</option> </option>
))} ))}
<option value="__custom__">Custom…</option> <option value="__custom__">Custom…</option>
</select> </FormSelect>
{selectValue === "__custom__" ? ( {selectValue === "__custom__" ? (
<input <FormInput
className="input input-sm w-full font-mono" className="w-full font-mono"
value={value} value={value}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange(e.target.value)} onChange={(e) => onChange(e.target.value)}
@@ -5,6 +5,7 @@ import { LuChevronDown, LuGripVertical, LuMaximize2, LuMinimize2, LuPlay, LuTras
import { useDryRunScript, useScript } from "../../api/hooks.js"; import { useDryRunScript, useScript } from "../../api/hooks.js";
import { errorMessage } from "../../api/client.js"; import { errorMessage } from "../../api/client.js";
import { CodeEditor } from "../CodeEditor.jsx"; import { CodeEditor } from "../CodeEditor.jsx";
import { FormInput, FormSelect, FormTextarea } from "../FormControls.jsx";
import { LogViewer } from "../LogViewer.jsx"; import { LogViewer } from "../LogViewer.jsx";
import { StatusBadge } from "../../lib/format.jsx"; import { StatusBadge } from "../../lib/format.jsx";
import { contextFromMeta, prettyJson } from "../../lib/script.js"; import { contextFromMeta, prettyJson } from "../../lib/script.js";
@@ -178,8 +179,8 @@ export function ScriptCard({
required required
description="JSONata evaluated against ctx (data, context, config). Result becomes the next step's data." description="JSONata evaluated against ctx (data, context, config). Result becomes the next step's data."
/> />
<textarea <FormTextarea
className="textarea textarea-sm w-full min-h-24 font-mono text-xs" className="w-full min-h-24 font-mono text-xs"
value={step.expression ?? ""} value={step.expression ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...step, expression: e.target.value })} onChange={(e) => onChange({ ...step, expression: e.target.value })}
@@ -204,8 +205,8 @@ export function ScriptCard({
<div className="collapse-content space-y-2"> <div className="collapse-content space-y-2">
<label className="form-control"> <label className="form-control">
<span className="label py-0 text-sm">id</span> <span className="label py-0 text-sm">id</span>
<input <FormInput
className={`input input-sm font-mono ${duplicateId ? "input-error" : ""}`} className={`font-mono ${duplicateId ? "input-error" : ""}`}
value={step.id ?? ""} value={step.id ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...step, id: e.target.value })} onChange={(e) => onChange({ ...step, id: e.target.value })}
@@ -223,8 +224,8 @@ export function ScriptCard({
/> />
<label className="form-control"> <label className="form-control">
<span className="label py-0 text-sm">when</span> <span className="label py-0 text-sm">when</span>
<input <FormInput
className="input input-sm w-full font-mono" className="w-full font-mono"
value={step.when ?? ""} value={step.when ?? ""}
disabled={disabled || Boolean(step.needs)} disabled={disabled || Boolean(step.needs)}
onChange={(e) => onChange({ ...step, when: e.target.value })} onChange={(e) => onChange({ ...step, when: e.target.value })}
@@ -265,8 +266,7 @@ function NeedsEditor({ step, otherSteps, disabled, onChange }) {
return ( return (
<div className="space-y-1"> <div className="space-y-1">
<span className="label py-0 text-sm">needs</span> <span className="label py-0 text-sm">needs</span>
<select <FormSelect
className="select select-sm"
value={mode} value={mode}
disabled={disabled} disabled={disabled}
onChange={(e) => setMode(e.target.value)} onChange={(e) => setMode(e.target.value)}
@@ -274,7 +274,7 @@ function NeedsEditor({ step, otherSteps, disabled, onChange }) {
<option value="none">None (trigger data / previous output)</option> <option value="none">None (trigger data / previous output)</option>
<option value="list">List of step ids</option> <option value="list">List of step ids</option>
<option value="map">Map alias → step id</option> <option value="map">Map alias → step id</option>
</select> </FormSelect>
{mode === "list" ? ( {mode === "list" ? (
<div className="flex flex-wrap gap-2 pt-1"> <div className="flex flex-wrap gap-2 pt-1">
{ids.length === 0 ? ( {ids.length === 0 ? (
@@ -324,8 +324,8 @@ function NeedsMap({ needs, ids, disabled, onChange }) {
<div className="space-y-1"> <div className="space-y-1">
{entries.map(([alias, from]) => ( {entries.map(([alias, from]) => (
<div key={alias} className="flex gap-1"> <div key={alias} className="flex gap-1">
<input <FormInput
className="input input-sm font-mono w-28" className="font-mono w-28"
value={alias} value={alias}
disabled={disabled} disabled={disabled}
onChange={(e) => { onChange={(e) => {
@@ -336,8 +336,8 @@ function NeedsMap({ needs, ids, disabled, onChange }) {
onChange(next); onChange(next);
}} }}
/> />
<select <FormSelect
className="select select-sm flex-1" className="flex-1"
value={from} value={from}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...needs, [alias]: e.target.value })} onChange={(e) => onChange({ ...needs, [alias]: e.target.value })}
@@ -348,7 +348,7 @@ function NeedsMap({ needs, ids, disabled, onChange }) {
{id} {id}
</option> </option>
))} ))}
</select> </FormSelect>
<button <button
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
@@ -5,6 +5,7 @@ import { CSS } from "@dnd-kit/utilities";
import cronstrue from "cronstrue"; import cronstrue from "cronstrue";
import { namespacedPath, HTTP_METHODS, triggerDestinations } from "../../lib/workflow-doc.js"; import { namespacedPath, HTTP_METHODS, triggerDestinations } from "../../lib/workflow-doc.js";
import { CRON_CUSTOM, CRON_PRESETS, matchCronPreset, scheduleForPreset } from "../../lib/cron-presets.js"; import { CRON_CUSTOM, CRON_PRESETS, matchCronPreset, scheduleForPreset } from "../../lib/cron-presets.js";
import { FormInput, FormSelect } from "../FormControls.jsx";
export function TriggerCard({ export function TriggerCard({
trigger, trigger,
@@ -169,8 +170,8 @@ function HttpFields({ trigger, owner, disabled, onChange, auths, pages, alertDes
return ( return (
<div className="space-y-3"> <div className="space-y-3">
<Field label="Method"> <Field label="Method">
<select <FormSelect
className="select select-bordered select-sm w-full" className="w-full"
value={trigger.method || "POST"} value={trigger.method || "POST"}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...trigger, method: e.target.value })} onChange={(e) => onChange({ ...trigger, method: e.target.value })}
@@ -183,12 +184,12 @@ function HttpFields({ trigger, owner, disabled, onChange, auths, pages, alertDes
{HTTP_METHODS.includes(trigger.method || "POST") ? null : ( {HTTP_METHODS.includes(trigger.method || "POST") ? null : (
<option value={trigger.method}>{trigger.method}</option> <option value={trigger.method}>{trigger.method}</option>
)} )}
</select> </FormSelect>
</Field> </Field>
<Field label="Path"> <Field label="Path">
<input <FormInput
className="input input-bordered input-sm w-full font-mono" className="w-full font-mono"
value={trigger.path ?? ""} value={trigger.path ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...trigger, path: e.target.value })} onChange={(e) => onChange({ ...trigger, path: e.target.value })}
@@ -198,8 +199,8 @@ function HttpFields({ trigger, owner, disabled, onChange, auths, pages, alertDes
<Field label="URL"> <Field label="URL">
<div className="flex w-full items-center gap-1"> <div className="flex w-full items-center gap-1">
<input <FormInput
className="input input-bordered input-sm w-full font-mono opacity-80" className="w-full font-mono opacity-80"
value={url} value={url}
readOnly readOnly
tabIndex={-1} tabIndex={-1}
@@ -224,8 +225,8 @@ function HttpFields({ trigger, owner, disabled, onChange, auths, pages, alertDes
/> />
<Field label="Response page"> <Field label="Response page">
<select <FormSelect
className="select select-bordered select-sm w-full" className="w-full"
value={trigger.response ?? ""} value={trigger.response ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...trigger, response: e.target.value })} onChange={(e) => onChange({ ...trigger, response: e.target.value })}
@@ -239,7 +240,7 @@ function HttpFields({ trigger, owner, disabled, onChange, auths, pages, alertDes
{trigger.response && !pages.some((p) => p.name === trigger.response) ? ( {trigger.response && !pages.some((p) => p.name === trigger.response) ? (
<option value={trigger.response}>{trigger.response}</option> <option value={trigger.response}>{trigger.response}</option>
) : null} ) : null}
</select> </FormSelect>
</Field> </Field>
<FailureAlertFields <FailureAlertFields
@@ -343,10 +344,10 @@ function AuthPicker({ auths, selectedIds, inlineCount, disabled, onChange }) {
<div className="relative w-full"> <div className="relative w-full">
<div className="join w-full"> <div className="join w-full">
<input <FormInput
ref={inputRef} ref={inputRef}
type="search" type="search"
className="input input-bordered input-sm join-item w-full min-w-0" className="join-item w-full min-w-0"
placeholder={auths.length === 0 ? "No auth profiles yet" : "Add auth…"} placeholder={auths.length === 0 ? "No auth profiles yet" : "Add auth…"}
value={query} value={query}
disabled={disabled || auths.length === 0} disabled={disabled || auths.length === 0}
@@ -424,8 +425,7 @@ function CronFields({ trigger, disabled, onChange, alertDestinations }) {
<div className="space-y-2"> <div className="space-y-2">
<label className="form-control"> <label className="form-control">
<span className="label py-0 text-sm">Preset</span> <span className="label py-0 text-sm">Preset</span>
<select <FormSelect
className="select select-sm"
value={preset} value={preset}
disabled={disabled} disabled={disabled}
onChange={(e) => { onChange={(e) => {
@@ -441,12 +441,12 @@ function CronFields({ trigger, disabled, onChange, alertDestinations }) {
</option> </option>
))} ))}
<option value={CRON_CUSTOM}>Custom</option> <option value={CRON_CUSTOM}>Custom</option>
</select> </FormSelect>
</label> </label>
<label className="form-control"> <label className="form-control">
<span className="label py-0 text-sm">Schedule</span> <span className="label py-0 text-sm">Schedule</span>
<input <FormInput
className="input input-sm font-mono" className="font-mono"
value={trigger.schedule ?? ""} value={trigger.schedule ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...trigger, schedule: e.target.value })} onChange={(e) => onChange({ ...trigger, schedule: e.target.value })}
@@ -473,8 +473,8 @@ function FailureAlertFields({ trigger, disabled, onChange, alertDestinations })
<div className="space-y-3 border-t border-base-300 pt-3"> <div className="space-y-3 border-t border-base-300 pt-3">
<p className="text-sm font-medium opacity-80">Failure alert</p> <p className="text-sm font-medium opacity-80">Failure alert</p>
<Field label="Consecutive failures"> <Field label="Consecutive failures">
<input <FormInput
className="input input-bordered input-sm w-full" className="w-full"
type="number" type="number"
min="1" min="1"
step="1" step="1"
@@ -496,8 +496,8 @@ function FailureAlertFields({ trigger, disabled, onChange, alertDestinations })
</> </>
} }
> >
<select <FormSelect
className="select select-bordered select-sm w-full" className="w-full"
value={trigger.onFailureWorkflow ?? ""} value={trigger.onFailureWorkflow ?? ""}
disabled={disabled} disabled={disabled}
onChange={(e) => onChange({ ...trigger, onFailureWorkflow: e.target.value })} onChange={(e) => onChange({ ...trigger, onFailureWorkflow: e.target.value })}
@@ -514,7 +514,7 @@ function FailureAlertFields({ trigger, disabled, onChange, alertDestinations })
) ? ( ) ? (
<option value={trigger.onFailureWorkflow}>{trigger.onFailureWorkflow}</option> <option value={trigger.onFailureWorkflow}>{trigger.onFailureWorkflow}</option>
) : null} ) : null}
</select> </FormSelect>
</Field> </Field>
</div> </div>
); );
@@ -12,7 +12,7 @@ import {
isSaveWarningsError, isSaveWarningsError,
saveWarningsFromError, saveWarningsFromError,
} from "./SaveWorkflowWarningsDialog.jsx"; } from "./SaveWorkflowWarningsDialog.jsx";
import { ConfirmDialog } from "./WorkflowRevisionBanner.jsx"; import { ConfirmDialog } from "../ConfirmDialog.jsx";
function reasonLabel(reason, meta) { function reasonLabel(reason, meta) {
if (reason === "duplicated" && meta?.from) return `duplicated from ${meta.from}`; if (reason === "duplicated" && meta?.from) return `duplicated from ${meta.from}`;
@@ -127,6 +127,7 @@ export function WorkflowHistoryPanel({
type="button" type="button"
className="btn btn-ghost btn-xs shrink-0" className="btn btn-ghost btn-xs shrink-0"
title="Revert to this revision" title="Revert to this revision"
aria-label="Revert to this revision"
disabled={revert.isPending} disabled={revert.isPending}
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
@@ -152,6 +153,7 @@ export function WorkflowHistoryPanel({
title={`Revert to revision #${confirmRev.revision}?`} title={`Revert to revision #${confirmRev.revision}?`}
message={`This replaces the live workflow with revision #${confirmRev.revision} from ${formatTime(confirmRev.created_at)} and creates a new revision.`} message={`This replaces the live workflow with revision #${confirmRev.revision} from ${formatTime(confirmRev.created_at)} and creates a new revision.`}
confirmLabel="Revert" confirmLabel="Revert"
confirmClass="btn-warning"
pending={revert.isPending} pending={revert.isPending}
onCancel={() => setConfirmRevision(null)} onCancel={() => setConfirmRevision(null)}
onConfirm={() => doRevert(confirmRev.revision, false)} onConfirm={() => doRevert(confirmRev.revision, false)}
@@ -4,52 +4,13 @@ import { errorMessage } from "../../api/client.js";
import { useRevertWorkflowRevision } from "../../api/hooks.js"; import { useRevertWorkflowRevision } from "../../api/hooks.js";
import { formatTime } from "../../lib/format.jsx"; import { formatTime } from "../../lib/format.jsx";
import { useNotifications } from "../../notifications.jsx"; import { useNotifications } from "../../notifications.jsx";
import { ConfirmDialog } from "../ConfirmDialog.jsx";
import { import {
SaveWorkflowWarningsDialog, SaveWorkflowWarningsDialog,
isSaveWarningsError, isSaveWarningsError,
saveWarningsFromError, saveWarningsFromError,
} from "./SaveWorkflowWarningsDialog.jsx"; } from "./SaveWorkflowWarningsDialog.jsx";
function ConfirmDialog({
open,
title,
message,
confirmLabel,
confirmClass = "btn-warning",
pending,
onCancel,
onConfirm,
}) {
if (!open) return null;
return (
<dialog className="modal modal-open">
<div className="modal-box max-w-md">
<h3 className="font-bold">{title}</h3>
<p className="mt-2 text-sm opacity-70">{message}</p>
<div className="modal-action">
<button type="button" className="btn btn-ghost" onClick={onCancel}>
Cancel
</button>
<button
type="button"
className={`btn ${confirmClass}`}
disabled={pending}
onClick={onConfirm}
>
{pending ? <span className="loading loading-spinner loading-xs" /> : null}
{confirmLabel}
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={onCancel}>
close
</button>
</form>
</dialog>
);
}
export function WorkflowRevisionBanner({ export function WorkflowRevisionBanner({
owner, owner,
file, file,
@@ -110,6 +71,7 @@ export function WorkflowRevisionBanner({
title={`Revert to revision #${revision}?`} title={`Revert to revision #${revision}?`}
message={`This replaces the live workflow with revision #${revision} from ${formatTime(createdAt)} and creates a new revision.`} message={`This replaces the live workflow with revision #${revision} from ${formatTime(createdAt)} and creates a new revision.`}
confirmLabel="Revert" confirmLabel="Revert"
confirmClass="btn-warning"
pending={revert.isPending} pending={revert.isPending}
onCancel={() => setConfirmOpen(false)} onCancel={() => setConfirmOpen(false)}
onConfirm={() => doRevert(false)} onConfirm={() => doRevert(false)}
@@ -125,5 +87,3 @@ export function WorkflowRevisionBanner({
</> </>
); );
} }
export { ConfirmDialog };
@@ -4,6 +4,7 @@ import { useHttpAuths, useHttpPages, useProfiles, useScripts, useWorkflows } fro
import { dataFromInputMeta, firstInputMeta } from "../../lib/script.js"; import { dataFromInputMeta, firstInputMeta } from "../../lib/script.js";
import { workflowToFlowchart } from "../../lib/workflow-mermaid.js"; import { workflowToFlowchart } from "../../lib/workflow-mermaid.js";
import { parseWorkflowYaml, stringifyWorkflowDoc } from "../../lib/workflow-doc.js"; import { parseWorkflowYaml, stringifyWorkflowDoc } from "../../lib/workflow-doc.js";
import { FormInput, FormTextarea } from "../FormControls.jsx";
import { ScriptsTab } from "./ScriptsTab.jsx"; import { ScriptsTab } from "./ScriptsTab.jsx";
import { TriggersTab } from "./TriggersTab.jsx"; import { TriggersTab } from "./TriggersTab.jsx";
import { YamlTab } from "./YamlTab.jsx"; import { YamlTab } from "./YamlTab.jsx";
@@ -119,8 +120,8 @@ export function WorkflowVisualEditor({
<> <>
<div className="flex shrink-0 flex-col gap-2 sm:flex-row sm:flex-wrap sm:items-center"> <div className="flex shrink-0 flex-col gap-2 sm:flex-row sm:flex-wrap sm:items-center">
{extraChrome} {extraChrome}
<input <FormInput
className="input input-sm sm:max-w-xs" className="sm:max-w-xs"
placeholder="name" placeholder="name"
value={displayDoc?.name ?? ""} value={displayDoc?.name ?? ""}
disabled={visualDisabled} disabled={visualDisabled}
@@ -130,8 +131,8 @@ export function WorkflowVisualEditor({
}) })
} }
/> />
<textarea <FormTextarea
className="textarea textarea-sm min-h-10 w-full sm:max-w-md" className="min-h-10 w-full sm:max-w-md"
placeholder="description" placeholder="description"
rows={1} rows={1}
value={displayDoc?.description ?? ""} value={displayDoc?.description ?? ""}
+15 -34
View File
@@ -8,6 +8,7 @@ import {
useHttpAuths, useHttpAuths,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { AuthEditorModal } from "../components/AuthEditorModal.jsx"; import { AuthEditorModal } from "../components/AuthEditorModal.jsx";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
function CredDisplay({ field, fieldKey, authId, cache, onRevealed }) { function CredDisplay({ field, fieldKey, authId, cache, onRevealed }) {
@@ -66,7 +67,7 @@ function CredDisplay({ field, fieldKey, authId, cache, onRevealed }) {
type="button" type="button"
className="btn btn-ghost btn-xs btn-square" className="btn btn-ghost btn-xs btn-square"
title={shown ? "Hide" : "Reveal"} title={shown ? "Hide" : "Reveal"}
aria-label={shown ? "Hide value" : "Reveal value"} aria-label={shown ? "Hide" : "Reveal"}
disabled={loading} disabled={loading}
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
@@ -241,6 +242,7 @@ export function AuthProfilesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
onClick={() => navigate(`/auth/${encodeURIComponent(a.name)}/edit`)} onClick={() => navigate(`/auth/${encodeURIComponent(a.name)}/edit`)}
> >
<LuPencil className="size-4" /> <LuPencil className="size-4" />
@@ -249,6 +251,7 @@ export function AuthProfilesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete" title="Delete"
aria-label="Delete"
onClick={() => setConfirmDelete(a)} onClick={() => setConfirmDelete(a)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -278,39 +281,17 @@ export function AuthProfilesPage() {
/> />
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Delete ${confirmDelete.name}?` : ""}
<h3 className="font-bold">Delete {confirmDelete.name}?</h3> message="Workflows that reference this profile will fail auth until updated."
<p className="text-sm mt-2"> error={del.isError ? errorMessage(del.error) : null}
Workflows that reference this profile will fail auth until updated. loading={del.isPending}
</p> onCancel={() => setConfirmDelete(null)}
{del.isError ? ( onConfirm={() =>
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
) : null} }
<div className="modal-action"> />
<button type="button" className="btn btn-ghost" onClick={() => setConfirmDelete(null)}>
Cancel
</button>
<button
type="button"
className="btn btn-error"
disabled={del.isPending}
onClick={() =>
del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
}
>
Delete
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+17 -33
View File
@@ -5,6 +5,7 @@ import {
useDownloadWorkflowBackup, useDownloadWorkflowBackup,
useRestoreWorkflowBackup, useRestoreWorkflowBackup,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { useNotifications } from "../notifications.jsx"; import { useNotifications } from "../notifications.jsx";
export function BackupPage() { export function BackupPage() {
@@ -120,40 +121,23 @@ export function BackupPage() {
</div> </div>
</section> </section>
{pendingFile ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(pendingFile)}
<div className="modal-box"> title="Replace with this backup?"
<h3 className="font-bold">Replace with this backup?</h3> message={
<p className="mt-2 text-sm opacity-70"> pendingFile ? (
<>
Current workflows and plugins will be deleted, then{" "} Current workflows and plugins will be deleted, then{" "}
<span className="font-mono">{pendingFile.name}</span> will be <span className="font-mono">{pendingFile.name}</span> will be restored. This cannot
restored. This cannot be undone from this page. be undone from this page.
</p> </>
<div className="modal-action"> ) : null
<button }
type="button" confirmLabel="Replace"
className="btn btn-ghost" loading={restoreBackup.isPending}
onClick={() => setPendingFile(null)} onCancel={() => setPendingFile(null)}
> onConfirm={() => restore(pendingFile, "replace")}
Cancel />
</button>
<button
type="button"
className="btn btn-error"
disabled={restoreBackup.isPending}
onClick={() => restore(pendingFile, "replace")}
>
Replace
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setPendingFile(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+13 -3
View File
@@ -1,6 +1,7 @@
import { useState } from "react"; import { useState } from "react";
import { useSearchParams } from "react-router-dom"; import { useSearchParams } from "react-router-dom";
import { useKv, useKvNamespaces } from "../api/hooks.js"; import { useKv, useKvNamespaces } from "../api/hooks.js";
import { FormSelect } from "../components/FormControls.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
const PAGE_SIZE = 50; const PAGE_SIZE = 50;
@@ -48,8 +49,8 @@ export function KvPage() {
<div className="space-y-4"> <div className="space-y-4">
<h1 className="text-xl font-semibold">KV</h1> <h1 className="text-xl font-semibold">KV</h1>
<div className="flex flex-col sm:flex-row gap-2"> <div className="flex flex-col sm:flex-row gap-2">
<select <FormSelect
className="select select-sm w-full sm:max-w-xs" className="w-full sm:max-w-xs"
value={namespace} value={namespace}
onChange={(e) => update("namespace", e.target.value)} onChange={(e) => update("namespace", e.target.value)}
> >
@@ -59,7 +60,7 @@ export function KvPage() {
{ns} {ns}
</option> </option>
))} ))}
</select> </FormSelect>
<input <input
className="input input-sm w-full sm:max-w-sm" className="input input-sm w-full sm:max-w-sm"
placeholder="search key or value" placeholder="search key or value"
@@ -93,6 +94,15 @@ export function KvPage() {
key={id} key={id}
className="hover cursor-pointer" className="hover cursor-pointer"
onClick={() => setExpanded(open ? null : id)} onClick={() => setExpanded(open ? null : id)}
onKeyDown={(e) => {
if (e.key === "Enter" || e.key === " ") {
e.preventDefault();
setExpanded(open ? null : id);
}
}}
role="button"
tabIndex={0}
aria-expanded={open}
> >
<td className="font-mono text-xs align-top">{item.namespace}</td> <td className="font-mono text-xs align-top">{item.namespace}</td>
<td className="font-mono text-xs align-top">{item.key}</td> <td className="font-mono text-xs align-top">{item.key}</td>
+56 -61
View File
@@ -3,6 +3,8 @@ import { useLocation, useNavigate, useParams, useSearchParams } from "react-rout
import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu"; import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useDeleteProfile, useOwners, useProfileUsage, useProfiles } from "../api/hooks.js"; import { useDeleteProfile, useOwners, useProfileUsage, useProfiles } from "../api/hooks.js";
import { FormSelect } from "../components/FormControls.jsx";
import { Modal } from "../components/Modal.jsx";
import { ProfileEditorModal } from "../components/ProfileEditorModal.jsx"; import { ProfileEditorModal } from "../components/ProfileEditorModal.jsx";
import { ScriptIcon } from "../components/ScriptIcon.jsx"; import { ScriptIcon } from "../components/ScriptIcon.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
@@ -129,8 +131,7 @@ export function ProfilesPage() {
<div className="flex flex-col sm:flex-row sm:items-center justify-between gap-2"> <div className="flex flex-col sm:flex-row sm:items-center justify-between gap-2">
<h1 className="text-xl font-semibold">Profiles</h1> <h1 className="text-xl font-semibold">Profiles</h1>
<div className="flex gap-2"> <div className="flex gap-2">
<select <FormSelect
className="select select-sm"
value={ownerFilter} value={ownerFilter}
onChange={(e) => { onChange={(e) => {
setOwnerFilter(e.target.value); setOwnerFilter(e.target.value);
@@ -149,7 +150,7 @@ export function ProfilesPage() {
{o} {o}
</option> </option>
))} ))}
</select> </FormSelect>
<button <button
type="button" type="button"
className="btn btn-primary btn-sm" className="btn btn-primary btn-sm"
@@ -224,6 +225,7 @@ export function ProfilesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
onClick={() => onClick={() =>
navigate( navigate(
`/profiles/${encodeURIComponent(row.owner)}/${encodeURIComponent(row.name)}/edit`, `/profiles/${encodeURIComponent(row.owner)}/${encodeURIComponent(row.name)}/edit`,
@@ -237,6 +239,7 @@ export function ProfilesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete" title="Delete"
aria-label="Delete"
onClick={() => setConfirmDelete({ ...row, force: false })} onClick={() => setConfirmDelete({ ...row, force: false })}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -281,66 +284,58 @@ function DeleteProfileDialog({ profile, del, onClose }) {
const usage = useProfileUsage(profile.id, true); const usage = useProfileUsage(profile.id, true);
const usages = usage.data ?? []; const usages = usage.data ?? [];
const used = usages.length > 0; const used = usages.length > 0;
const title = `Delete ${profile.owner}/${profile.name}?`;
return ( return (
<dialog className="modal modal-open"> <Modal open onClose={onClose} boxClassName="max-w-md" aria-label={title}>
<div className="modal-box"> <h3 className="font-bold">{title}</h3>
<h3 className="font-bold"> {usage.isLoading ? (
Delete {profile.owner}/{profile.name}? <p className="text-sm mt-2 opacity-70">Checking workflow usage…</p>
</h3> ) : used ? (
{usage.isLoading ? ( <>
<p className="text-sm mt-2 opacity-70">Checking workflow usage…</p> <p className="text-sm mt-2">{formatUsage(usages)}</p>
) : used ? ( <ul className="mt-2 max-h-40 overflow-auto text-sm font-mono">
<> {usages.map((u) => (
<p className="text-sm mt-2">{formatUsage(usages)}</p> <li key={u.file}>
<ul className="mt-2 max-h-40 overflow-auto text-sm font-mono"> {u.name}
{usages.map((u) => ( {u.file !== u.name ? ` (${u.file})` : ""}
<li key={u.file}> </li>
{u.name} ))}
{u.file !== u.name ? ` (${u.file})` : ""} </ul>
</li> {force ? (
))} <p className="text-warning text-sm mt-2">
</ul> Workflows that still reference this profile will fail until you fix them.
{force ? ( </p>
<p className="text-warning text-sm mt-2"> ) : null}
Workflows that still reference this profile will fail until you fix them. </>
</p> ) : (
) : null} <p className="text-sm mt-2">This cannot be undone.</p>
</> )}
) : ( {del.isError ? (
<p className="text-sm mt-2">This cannot be undone.</p> <p className="text-error text-sm mt-2">{errorMessage(del.error)}</p>
)} ) : null}
{del.isError ? ( <div className="modal-action">
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> <button type="button" className="btn btn-ghost" onClick={onClose}>
) : null} Cancel
<div className="modal-action">
<button type="button" className="btn btn-ghost" onClick={onClose}>
Cancel
</button>
{used && !force ? (
<button type="button" className="btn btn-warning" onClick={() => setForce(true)}>
Force delete
</button>
) : (
<button
type="button"
className="btn btn-error"
disabled={del.isPending || usage.isLoading}
onClick={() =>
del.mutate({ id: profile.id, force: used }, { onSuccess: () => onClose() })
}
>
{del.isPending ? <span className="loading loading-spinner loading-xs" /> : null}
Delete
</button>
)}
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={onClose}>
close
</button> </button>
</form> {used && !force ? (
</dialog> <button type="button" className="btn btn-warning" onClick={() => setForce(true)}>
Force delete
</button>
) : (
<button
type="button"
className="btn btn-error"
disabled={del.isPending || usage.isLoading}
onClick={() =>
del.mutate({ id: profile.id, force: used }, { onSuccess: () => onClose() })
}
>
{del.isPending ? <span className="loading loading-spinner loading-xs" /> : null}
Delete
</button>
)}
</div>
</Modal>
); );
} }
+15 -33
View File
@@ -6,6 +6,7 @@ import {
useHttpPages, useHttpPages,
useUpsertHttpPage, useUpsertHttpPage,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
const emptyForm = { const emptyForm = {
@@ -116,6 +117,7 @@ export function ResponsesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
onClick={() => openEdit(p)} onClick={() => openEdit(p)}
> >
<LuPencil className="size-4" /> <LuPencil className="size-4" />
@@ -124,6 +126,7 @@ export function ResponsesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title={p.system ? "System pages cannot be deleted" : "Delete"} title={p.system ? "System pages cannot be deleted" : "Delete"}
aria-label={p.system ? "System pages cannot be deleted" : "Delete"}
disabled={p.system} disabled={p.system}
onClick={() => setConfirmDelete(p)} onClick={() => setConfirmDelete(p)}
> >
@@ -227,39 +230,18 @@ export function ResponsesPage() {
</form> </form>
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Delete ${confirmDelete.name}?` : ""}
<h3 className="font-bold">Delete {confirmDelete.name}?</h3> message="Workflows that reference this page will fail validation on next save."
<p className="text-sm mt-2"> error={del.isError ? errorMessage(del.error) : null}
Workflows that reference this page will fail validation on next save. loading={del.isPending}
</p> confirmDisabled={Boolean(confirmDelete?.system)}
{del.isError ? ( onCancel={() => setConfirmDelete(null)}
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> onConfirm={() =>
) : null} del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
<div className="modal-action"> }
<button type="button" className="btn btn-ghost" onClick={() => setConfirmDelete(null)}> />
Cancel
</button>
<button
type="button"
className="btn btn-error"
disabled={del.isPending || confirmDelete.system}
onClick={() =>
del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
}
>
Delete
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+18 -37
View File
@@ -8,6 +8,7 @@ import {
useInstallPlugin, useInstallPlugin,
useScripts, useScripts,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { ScriptIcon } from "../components/ScriptIcon.jsx"; import { ScriptIcon } from "../components/ScriptIcon.jsx";
import { TagBadge } from "../components/TagBadge.jsx"; import { TagBadge } from "../components/TagBadge.jsx";
import { scriptTags } from "../lib/script.js"; import { scriptTags } from "../lib/script.js";
@@ -156,6 +157,7 @@ export function ScriptsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Dry run" title="Dry run"
aria-label="Dry run"
onClick={() => onClick={() =>
navigate(`/scripts/${encodeURIComponent(name)}/dry-run`) navigate(`/scripts/${encodeURIComponent(name)}/dry-run`)
} }
@@ -167,6 +169,7 @@ export function ScriptsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Fork" title="Fork"
aria-label="Fork"
onClick={() => { onClick={() => {
setForkFor(name); setForkFor(name);
setForkId( setForkId(
@@ -183,6 +186,7 @@ export function ScriptsPage() {
to={`/scripts/${encodeURIComponent(name)}/edit`} to={`/scripts/${encodeURIComponent(name)}/edit`}
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
> >
<LuPencil className="size-4" /> <LuPencil className="size-4" />
</Link> </Link>
@@ -192,6 +196,7 @@ export function ScriptsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete" title="Delete"
aria-label="Delete"
onClick={() => setConfirmDelete(name)} onClick={() => setConfirmDelete(name)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -259,43 +264,19 @@ export function ScriptsPage() {
</dialog> </dialog>
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Delete ${confirmDelete}?` : ""}
<h3 className="font-semibold">Delete {confirmDelete}?</h3> message="This uninstalls the plugin."
<p className="text-sm opacity-70 py-2">This uninstalls the plugin.</p> error={del.isError ? errorMessage(del.error) : null}
{del.isError ? ( loading={del.isPending}
<p className="text-error text-sm">{errorMessage(del.error)}</p> onCancel={() => setConfirmDelete(null)}
) : null} onConfirm={() =>
<div className="modal-action"> del.mutate(confirmDelete, {
<button onSuccess: () => setConfirmDelete(null),
type="button" })
className="btn btn-ghost btn-sm" }
onClick={() => setConfirmDelete(null)} />
>
Cancel
</button>
<button
type="button"
className="btn btn-error btn-sm"
disabled={del.isPending}
onClick={() =>
del.mutate(confirmDelete, {
onSuccess: () => setConfirmDelete(null),
})
}
>
Delete
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+17 -38
View File
@@ -3,6 +3,8 @@ import { useLocation, useNavigate, useParams, useSearchParams } from "react-rout
import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu"; import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useDeleteSecret, useOwners, useSecrets } from "../api/hooks.js"; import { useDeleteSecret, useOwners, useSecrets } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { FormSelect } from "../components/FormControls.jsx";
import { SecretEditorModal } from "../components/SecretEditorModal.jsx"; import { SecretEditorModal } from "../components/SecretEditorModal.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
@@ -81,8 +83,7 @@ export function SecretsPage() {
<div className="flex flex-col sm:flex-row sm:items-center justify-between gap-2"> <div className="flex flex-col sm:flex-row sm:items-center justify-between gap-2">
<h1 className="text-xl font-semibold">Secrets</h1> <h1 className="text-xl font-semibold">Secrets</h1>
<div className="flex gap-2"> <div className="flex gap-2">
<select <FormSelect
className="select select-sm"
value={ownerFilter} value={ownerFilter}
onChange={(e) => { onChange={(e) => {
setOwnerFilter(e.target.value); setOwnerFilter(e.target.value);
@@ -101,7 +102,7 @@ export function SecretsPage() {
{o} {o}
</option> </option>
))} ))}
</select> </FormSelect>
<button <button
type="button" type="button"
className="btn btn-primary btn-sm" className="btn btn-primary btn-sm"
@@ -154,6 +155,7 @@ export function SecretsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Replace value" title="Replace value"
aria-label="Replace value"
onClick={() => onClick={() =>
navigate( navigate(
`/secrets/${encodeURIComponent(s.owner)}/${encodeURIComponent(s.name)}/edit`, `/secrets/${encodeURIComponent(s.owner)}/${encodeURIComponent(s.name)}/edit`,
@@ -166,6 +168,7 @@ export function SecretsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete" title="Delete"
aria-label="Delete"
onClick={() => setConfirmDelete(s)} onClick={() => setConfirmDelete(s)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -190,41 +193,17 @@ export function SecretsPage() {
/> />
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Delete ${confirmDelete.owner}/${confirmDelete.name}?` : ""}
<h3 className="font-bold"> message="This cannot be undone. Workflows that retrieve this name will fail."
Delete {confirmDelete.owner}/{confirmDelete.name}? error={del.isError ? errorMessage(del.error) : null}
</h3> loading={del.isPending}
<p className="text-sm mt-2"> onCancel={() => setConfirmDelete(null)}
This cannot be undone. Workflows that retrieve this name will fail. onConfirm={() =>
</p> del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
{del.isError ? ( }
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> />
) : null}
<div className="modal-action">
<button type="button" className="btn btn-ghost" onClick={() => setConfirmDelete(null)}>
Cancel
</button>
<button
type="button"
className="btn btn-error"
disabled={del.isPending}
onClick={() =>
del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
}
>
Delete
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+13 -30
View File
@@ -3,6 +3,7 @@ import { useLocation, useNavigate, useParams } from "react-router-dom";
import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu"; import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useDeleteUser, useUsers } from "../api/hooks.js"; import { useDeleteUser, useUsers } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { UserEditorModal } from "../components/UserEditorModal.jsx"; import { UserEditorModal } from "../components/UserEditorModal.jsx";
export function UsersPage() { export function UsersPage() {
@@ -88,6 +89,7 @@ export function UsersPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
onClick={() => onClick={() =>
navigate(`/users/${encodeURIComponent(u.username)}/edit`) navigate(`/users/${encodeURIComponent(u.username)}/edit`)
} }
@@ -98,6 +100,7 @@ export function UsersPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete" title="Delete"
aria-label="Delete"
onClick={() => setConfirmDelete(u)} onClick={() => setConfirmDelete(u)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -118,36 +121,16 @@ export function UsersPage() {
/> />
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Delete ${confirmDelete.username}?` : ""}
<h3 className="font-bold">Delete {confirmDelete.username}?</h3> error={del.isError ? errorMessage(del.error) : null}
{del.isError ? ( loading={del.isPending}
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> onCancel={() => setConfirmDelete(null)}
) : null} onConfirm={() =>
<div className="modal-action"> del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
<button type="button" className="btn btn-ghost" onClick={() => setConfirmDelete(null)}> }
Cancel />
</button>
<button
type="button"
className="btn btn-error"
disabled={del.isPending}
onClick={() =>
del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
}
>
Delete
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+21 -38
View File
@@ -3,6 +3,8 @@ import { useLocation, useNavigate, useParams, useSearchParams } from "react-rout
import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu"; import { LuPencil, LuPlus, LuTrash2 } from "react-icons/lu";
import { errorMessage } from "../api/client.js"; import { errorMessage } from "../api/client.js";
import { useDeleteVariable, useOwners, useVariables } from "../api/hooks.js"; import { useDeleteVariable, useOwners, useVariables } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { FormSelect } from "../components/FormControls.jsx";
import { VariableEditorModal } from "../components/VariableEditorModal.jsx"; import { VariableEditorModal } from "../components/VariableEditorModal.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
@@ -110,8 +112,7 @@ export function VariablesPage() {
<div className="flex flex-col sm:flex-row sm:items-center justify-between gap-2"> <div className="flex flex-col sm:flex-row sm:items-center justify-between gap-2">
<h1 className="text-xl font-semibold">Variables</h1> <h1 className="text-xl font-semibold">Variables</h1>
<div className="flex gap-2"> <div className="flex gap-2">
<select <FormSelect
className="select select-sm"
value={ownerFilter} value={ownerFilter}
onChange={(e) => { onChange={(e) => {
setOwnerFilter(e.target.value); setOwnerFilter(e.target.value);
@@ -130,7 +131,7 @@ export function VariablesPage() {
{o} {o}
</option> </option>
))} ))}
</select> </FormSelect>
<button <button
type="button" type="button"
className="btn btn-primary btn-sm" className="btn btn-primary btn-sm"
@@ -192,6 +193,7 @@ export function VariablesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
onClick={() => onClick={() =>
navigate( navigate(
`/variables/${encodeURIComponent(row.owner)}/${encodeURIComponent(row.name)}/edit`, `/variables/${encodeURIComponent(row.owner)}/${encodeURIComponent(row.name)}/edit`,
@@ -204,6 +206,7 @@ export function VariablesPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete" title="Delete"
aria-label="Delete"
onClick={() => setConfirmDelete(row)} onClick={() => setConfirmDelete(row)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -228,41 +231,21 @@ export function VariablesPage() {
/> />
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Delete ${confirmDelete.owner}/${confirmDelete.name}?` : ""}
<h3 className="font-bold"> message={
Delete {confirmDelete.owner}/{confirmDelete.name}? confirmDelete
</h3> ? `This cannot be undone. Workflows that reference $VAR_${confirmDelete.name} will fail.`
<p className="text-sm mt-2"> : ""
This cannot be undone. Workflows that reference $VAR_{confirmDelete.name} will fail. }
</p> error={del.isError ? errorMessage(del.error) : null}
{del.isError ? ( loading={del.isPending}
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> onCancel={() => setConfirmDelete(null)}
) : null} onConfirm={() =>
<div className="modal-action"> del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
<button type="button" className="btn btn-ghost" onClick={() => setConfirmDelete(null)}> }
Cancel />
</button>
<button
type="button"
className="btn btn-error"
disabled={del.isPending}
onClick={() =>
del.mutate(confirmDelete.id, { onSuccess: () => setConfirmDelete(null) })
}
>
Delete
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+3 -4
View File
@@ -20,10 +20,8 @@ import {
saveErrorMessage, saveErrorMessage,
saveWarningsFromError, saveWarningsFromError,
} from "../components/workflow/SaveWorkflowWarningsDialog.jsx"; } from "../components/workflow/SaveWorkflowWarningsDialog.jsx";
import { import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
ConfirmDialog, import { WorkflowRevisionBanner } from "../components/workflow/WorkflowRevisionBanner.jsx";
WorkflowRevisionBanner,
} from "../components/workflow/WorkflowRevisionBanner.jsx";
import { NEW_WORKFLOW_YAML, parseWorkflowYaml } from "../lib/workflow-doc.js"; import { NEW_WORKFLOW_YAML, parseWorkflowYaml } from "../lib/workflow-doc.js";
import { useNotifications } from "../notifications.jsx"; import { useNotifications } from "../notifications.jsx";
@@ -465,6 +463,7 @@ export function WorkflowEditPage() {
title="Discard unsaved changes?" title="Discard unsaved changes?"
message="You have unsaved edits. Switching versions will discard them." message="You have unsaved edits. Switching versions will discard them."
confirmLabel="Discard" confirmLabel="Discard"
confirmClass="btn-warning"
pending={false} pending={false}
onCancel={() => setDiscardConfirm(null)} onCancel={() => setDiscardConfirm(null)}
onConfirm={() => { onConfirm={() => {
+23 -40
View File
@@ -7,6 +7,7 @@ import {
useRestoreWorkflowTrash, useRestoreWorkflowTrash,
useWorkflowTrash, useWorkflowTrash,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { formatTime } from "../lib/format.jsx"; import { formatTime } from "../lib/format.jsx";
import { useNotifications } from "../notifications.jsx"; import { useNotifications } from "../notifications.jsx";
@@ -87,6 +88,7 @@ export function WorkflowTrashPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Restore" title="Restore"
aria-label="Restore"
disabled={restore.isPending} disabled={restore.isPending}
onClick={() => onClick={() =>
restore.mutate(item.id, { restore.mutate(item.id, {
@@ -105,6 +107,7 @@ export function WorkflowTrashPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Delete permanently" title="Delete permanently"
aria-label="Delete permanently"
onClick={() => setConfirmPurge(item)} onClick={() => setConfirmPurge(item)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -117,46 +120,26 @@ export function WorkflowTrashPage() {
</div> </div>
)} )}
{confirmPurge ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmPurge)}
<div className="modal-box"> title="Delete permanently?"
<h3 className="font-bold">Delete permanently?</h3> message={
<p className="mt-2 text-sm"> confirmPurge
{confirmPurge.name ?? confirmPurge.file} ({confirmPurge.owner}/{confirmPurge.file}) ? `${confirmPurge.name ?? confirmPurge.file} (${confirmPurge.owner}/${confirmPurge.file}) will be removed forever, including revision history.`
will be removed forever, including revision history. : ""
</p> }
<div className="modal-action"> confirmLabel="Delete forever"
<button loading={purge.isPending}
type="button" onCancel={() => setConfirmPurge(null)}
className="btn btn-ghost" onConfirm={() =>
onClick={() => setConfirmPurge(null)} purge.mutate(confirmPurge.id, {
> onSuccess: () => {
Cancel notify.success("Permanently deleted");
</button> setConfirmPurge(null);
<button },
type="button" })
className="btn btn-error" }
disabled={purge.isPending} />
onClick={() =>
purge.mutate(confirmPurge.id, {
onSuccess: () => {
notify.success("Permanently deleted");
setConfirmPurge(null);
},
})
}
>
Delete forever
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmPurge(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }
+27 -38
View File
@@ -10,6 +10,7 @@ import {
useWorkflows, useWorkflows,
} from "../api/hooks.js"; } from "../api/hooks.js";
import { DuplicateWorkflowDialog } from "../components/DuplicateWorkflowDialog.jsx"; import { DuplicateWorkflowDialog } from "../components/DuplicateWorkflowDialog.jsx";
import { ConfirmDialog } from "../components/ConfirmDialog.jsx";
import { WorkflowFileIcon } from "../components/WorkflowFileIcon.jsx"; import { WorkflowFileIcon } from "../components/WorkflowFileIcon.jsx";
import { formatTime, WorkflowStatusBadge } from "../lib/format.jsx"; import { formatTime, WorkflowStatusBadge } from "../lib/format.jsx";
@@ -80,6 +81,7 @@ export function WorkflowsPage() {
type="button" type="button"
className="btn btn-ghost btn-sm" className="btn btn-ghost btn-sm"
title="Reregister workflows" title="Reregister workflows"
aria-label="Reregister workflows"
disabled={reregister.isPending} disabled={reregister.isPending}
onClick={() => reregister.mutate()} onClick={() => reregister.mutate()}
> >
@@ -153,7 +155,11 @@ export function WorkflowsPage() {
<td className="whitespace-nowrap">{formatTime(w.lastInvokedAt)}</td> <td className="whitespace-nowrap">{formatTime(w.lastInvokedAt)}</td>
<td>{w.invocationCount}</td> <td>{w.invocationCount}</td>
<td className="text-right whitespace-nowrap"> <td className="text-right whitespace-nowrap">
<label className="inline-flex items-center mr-1" title={w.enabled ? "Disable" : "Enable"}> <label
className="inline-flex items-center mr-1"
title={w.enabled ? "Disable" : "Enable"}
aria-label={w.enabled ? "Disable" : "Enable"}
>
<input <input
type="checkbox" type="checkbox"
className="toggle toggle-success toggle-xs" className="toggle toggle-success toggle-xs"
@@ -172,6 +178,7 @@ export function WorkflowsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Run" title="Run"
aria-label="Run"
disabled={Boolean(w.loadError) || runningKey === w.key} disabled={Boolean(w.loadError) || runningKey === w.key}
onClick={() => onRun(w)} onClick={() => onRun(w)}
> >
@@ -184,6 +191,7 @@ export function WorkflowsPage() {
<Link <Link
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Events" title="Events"
aria-label="Events"
to={`/events?workflow=${encodeURIComponent(w.key)}`} to={`/events?workflow=${encodeURIComponent(w.key)}`}
> >
<LuActivity className="size-4" /> <LuActivity className="size-4" />
@@ -191,6 +199,7 @@ export function WorkflowsPage() {
<Link <Link
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Edit" title="Edit"
aria-label="Edit"
to={`/workflows/${encodeURIComponent(w.owner)}/${encodeURIComponent(w.file)}/edit`} to={`/workflows/${encodeURIComponent(w.owner)}/${encodeURIComponent(w.file)}/edit`}
> >
<LuPencil className="size-4" /> <LuPencil className="size-4" />
@@ -199,6 +208,7 @@ export function WorkflowsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs" className="btn btn-ghost btn-xs"
title="Duplicate" title="Duplicate"
aria-label="Duplicate"
disabled={Boolean(w.loadError)} disabled={Boolean(w.loadError)}
onClick={() => setDuplicateSource(w)} onClick={() => setDuplicateSource(w)}
> >
@@ -208,6 +218,7 @@ export function WorkflowsPage() {
type="button" type="button"
className="btn btn-ghost btn-xs text-error" className="btn btn-ghost btn-xs text-error"
title="Move to trash" title="Move to trash"
aria-label="Move to trash"
onClick={() => setConfirmDelete(w)} onClick={() => setConfirmDelete(w)}
> >
<LuTrash2 className="size-4" /> <LuTrash2 className="size-4" />
@@ -233,43 +244,21 @@ export function WorkflowsPage() {
/> />
) : null} ) : null}
{confirmDelete ? ( <ConfirmDialog
<dialog className="modal modal-open"> open={Boolean(confirmDelete)}
<div className="modal-box"> title={confirmDelete ? `Move ${confirmDelete.key} to trash?` : ""}
<h3 className="font-bold">Move {confirmDelete.key} to trash?</h3> message="The workflow is removed from the list but kept in trash for 7 days. Revision history is preserved."
<p className="mt-2 text-sm opacity-70"> confirmLabel="Move to trash"
The workflow is removed from the list but kept in trash for 7 days. Revision history error={del.isError ? errorMessage(del.error) : null}
is preserved. loading={del.isPending}
</p> onCancel={() => setConfirmDelete(null)}
{del.isError ? ( onConfirm={() =>
<p className="text-error text-sm mt-2">{errorMessage(del.error)}</p> del.mutate(
) : null} { owner: confirmDelete.owner, file: confirmDelete.file },
<div className="modal-action"> { onSuccess: () => setConfirmDelete(null) },
<button type="button" className="btn btn-ghost" onClick={() => setConfirmDelete(null)}> )
Cancel }
</button> />
<button
type="button"
className="btn btn-error"
disabled={del.isPending}
onClick={() =>
del.mutate(
{ owner: confirmDelete.owner, file: confirmDelete.file },
{ onSuccess: () => setConfirmDelete(null) },
)
}
>
Move to trash
</button>
</div>
</div>
<form method="dialog" className="modal-backdrop">
<button type="button" onClick={() => setConfirmDelete(null)}>
close
</button>
</form>
</dialog>
) : null}
</div> </div>
); );
} }